Pre commit hook #1073
Pre commit hook #1073
Conversation
arturfalcao
requested review from
cx-ben-alvo,
cx-daniel-greenspan and
cx-miryam-foifer
as code owners
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 15671991 | Triggered | Generic High Entropy Secret | cc0acc3 | internal/wrappers/client_test.go | View secret |
| 15776160 | Triggered | Generic High Entropy Secret | cc0acc3 | test/integration/scan_test.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
Great job, no security vulnerabilities found in this Pull Request |
test/integration/pre_commit_test.go
Outdated
| "testing" | ||
| ) | ||
|
|
||
| func TestPreCommitInstall(t *testing.T) { |
There was a problem hiding this comment.
Pls Add a test for a user that doesnt not have license to run this command
There was a problem hiding this comment.
this test was added by Elchanan Arbiv can you please ask in to update ?
arturfalcao
force-pushed
the
pre-commit-hook
branch
4 times, most recently
from
860b75d to
40f0f09
Compare
arturfalcao
force-pushed
the
pre-commit-hook
branch
from
9f57036 to
e1cf555
Compare
3 participants
By submitting this pull request, you agree to the terms within the Checkmarx Code of Conduct. Please review the contributing guidelines for guidance on creating high-quality pull requests.
Description
Please provide a summary of the changes and the related issue. Include relevant motivation and context.
Type of Change
Related Issues
Link any related issues or tickets.
Checklist
Screenshots (if applicable)
Add screenshots to help explain your changes.
Additional Notes
Add any other relevant information.