Skip to content

Triage-cmd-err-msg-for-mandatory-comment-for-ne-pne-state(AST-78029) #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cx-hitesh-madgulkar merged 6 commits into from
Aug 14, 2025
Merged

Triage-cmd-err-msg-for-mandatory-comment-for-ne-pne-state(AST-78029) #1259

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d59cb6c
skipping-tranforming-err-msg-for-ne-pne-missing-comment
cx-hitesh-madgulkar Aug 4, 2025
1945485
Merge branch 'main' of https://github.com/Checkmarx/ast-cli into feat…
cx-hitesh-madgulkar Aug 11, 2025
6b9d55e
Merge branch 'main' of https://github.com/Checkmarx/ast-cli into feat…
cx-hitesh-madgulkar Aug 12, 2025
79ca30b
Merge branch 'main' of https://github.com/Checkmarx/ast-cli into feat…
cx-hitesh-madgulkar Aug 12, 2025
af98e32
Merge branch 'main' of https://github.com/Checkmarx/ast-cli into feat…
cx-hitesh-madgulkar Aug 13, 2025
b6d4463
Merge branch 'main' into feature/ast-78029-mandatory-comment-message
cx-hitesh-madgulkar Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions internal/wrappers/predicates-http.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,22 @@ func (r ResultsPredicatesHTTPWrapper) PredicateSeverityAndState(predicate *Predi
_ = resp.Body.Close()
}()

// in case of ne/pne when mandatory comment arent provided, cli is not transforming error message
responseMap := make(map[string]interface{})
if err := json.NewDecoder(resp.Body).Decode(&responseMap); err != nil {
logger.PrintIfVerbose(fmt.Sprintf("failed to read the response, %v", err.Error()))
} else {
if val, ok := responseMap["code"].(float64); ok {
if val == 4002 && responseMap["message"] != nil {
if errMsg, ok := responseMap["message"].(string); ok {
if errMsg == "A comment is required to make changes to the result state" {
return nil, errors.Errorf(errMsg)
}
}
}
}
}

switch resp.StatusCode {
case http.StatusBadRequest, http.StatusInternalServerError:
return nil, errors.Errorf("Predicate bad request.")
Expand Down
Loading