Skip to content

Remove file path from secrets ignore flow (AST-00000) #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cx-itay-paz wants to merge 1 commit into from
Closed

Remove file path from secrets ignore flow (AST-00000) #1284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion internal/services/realtimeengine/secretsrealtime/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,5 @@ type SecretsRealtimeResult struct {

type IgnoredSecret struct {
Title string `json:"Title"`
FilePath string `json:"FilePath"`
SecretValue string `json:"SecretValue"`
}
4 changes: 2 additions & 2 deletions internal/services/realtimeengine/secretsrealtime/secrets-realtime.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ func NewSecretsRealtimeService(
func filterIgnoredSecrets(results []SecretsRealtimeResult, ignoreMap map[string]bool) []SecretsRealtimeResult {
filtered := make([]SecretsRealtimeResult, 0, len(results))
for _, r := range results {
key := fmt.Sprintf("%s_%s_%s", r.Title, r.FilePath, r.SecretValue)
key := fmt.Sprintf("%s_%s", r.Title, r.SecretValue)
if !ignoreMap[key] {
filtered = append(filtered, r)
}
Expand All @@ -56,7 +56,7 @@ func filterIgnoredSecrets(results []SecretsRealtimeResult, ignoreMap map[string]
func buildIgnoreMap(ignored []IgnoredSecret) map[string]bool {
m := make(map[string]bool)
for _, s := range ignored {
key := fmt.Sprintf("%s_%s_%s", s.Title, s.FilePath, s.SecretValue)
key := fmt.Sprintf("%s_%s", s.Title, s.SecretValue)
m[key] = true
}
return m
Expand Down
2 changes: 1 addition & 1 deletion internal/services/realtimeengine/secretsrealtime/secrets-realtime_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ func TestRunSecretsRealtimeScan_WithIgnoreFile_FiltersResult(t *testing.T) {

ignoreFile := filepath.Join(tempDir, "ignored.json")
ignored := []IgnoredSecret{
{Title: "github-pat", FilePath: testFile, SecretValue: "ghp_1234567890abcdef123"},
{Title: "github-pat", SecretValue: "ghp_1234567890abcdef123"},
}
data, _ := json.Marshal(ignored)
assert.NoError(t, os.WriteFile(ignoreFile, data, 0644))
Expand Down
Loading