Skip to content

Support SCS Secret Detection results for Jetbrains agent in JSON report(AST-110764) #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cx-atish-jadhav merged 3 commits into from
Sep 12, 2025
Merged

Support SCS Secret Detection results for Jetbrains agent in JSON report(AST-110764) #1297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c570a67
Support SCS Secret Detection results for Jetbrains agent in JSON report
cx-atish-jadhav Sep 1, 2025
0bdd905
Resolved SCS resubmission issue and updated JetBrains test case name …
cx-atish-jadhav Sep 11, 2025
04b1f01
Merge branch 'main' into feature/SCS-Jetbrains
cx-atish-jadhav Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/commands/result.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1158,7 +1158,7 @@ func filterResultsByType(results *wrappers.ScanResultsCollection, excludedTypes
func filterScsResultsByAgent(results *wrappers.ScanResultsCollection, agent string) *wrappers.ScanResultsCollection {
unsupportedTypesByAgent := map[string][]string{
commonParams.VSCodeAgent: {commonParams.SCSScorecardType},
commonParams.JetbrainsAgent: {commonParams.SCSScorecardType, commonParams.SCSSecretDetectionType},
commonParams.JetbrainsAgent: {commonParams.SCSScorecardType},
commonParams.EclipseAgent: {commonParams.SCSScorecardType, commonParams.SCSSecretDetectionType},
commonParams.VisualStudioAgent: {commonParams.SCSScorecardType, commonParams.SCSSecretDetectionType},
}
Expand Down
6 changes: 3 additions & 3 deletions internal/commands/result_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ func TestRunScsResultsShow_VSCode_AgentShouldNotShowScorecardResults(t *testing.
mock.SetScsMockVarsToDefault()
}

func TestRunScsResultsShow_Other_AgentsShouldNotShowScsResults(t *testing.T) {
func TestRunScsResultsShow_Jetbrains_AgentShouldShowScsResults(t *testing.T) {
clearFlags()
mock.HasScs = true
mock.ScsScanPartial = false
Expand All @@ -206,8 +206,8 @@ func TestRunScsResultsShow_Other_AgentsShouldNotShowScsResults(t *testing.T) {

execCmdNilAssertion(t, "results", "show", "--scan-id", "SCS_ONLY", "--report-format", "json", "--agent", params.JetbrainsAgent)
assertTypePresentJSON(t, params.SCSScorecardType, 0)
assertTypePresentJSON(t, params.SCSSecretDetectionType, 0)
assertTotalCountJSON(t, 0)
assertTypePresentJSON(t, params.SCSSecretDetectionType, 2)
assertTotalCountJSON(t, 2)

removeFileBySuffix(t, printer.FormatJSON)
mock.SetScsMockVarsToDefault()
Expand Down
1 change: 1 addition & 0 deletions internal/commands/scan.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1030,6 +1030,7 @@ func getResubmitConfiguration(scansWrapper wrappers.ScansWrapper, projectID, use

if len(allScansModel.Scans) > 0 {
scanModelResponse := allScansModel.Scans[0]
scanModelResponse.ReplaceMicroEnginesWithSCS()
config = scanModelResponse.Metadata.Configs
engines := scanModelResponse.Engines
// Check if there are no scan types sent using the flags, and use the latest scan engine types
Expand Down
Loading