Skip to content

Added helper function for github api limit(AST-114482) #1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cx-sumit-morchhale wants to merge 7 commits into from
Closed

Added helper function for github api limit(AST-114482) #1315

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
17e453f
Added helper function for git api limit
cx-sumit-morchhale Sep 24, 2025
08ef49b
fix lint issue
cx-sumit-morchhale Sep 24, 2025
0702c86
code refactor
cx-sumit-morchhale Sep 24, 2025
599ffd4
Added unit test cases
cx-sumit-morchhale Sep 25, 2025
dabeb52
fix the lint issue
cx-sumit-morchhale Sep 25, 2025
098200f
fix lint issue
cx-sumit-morchhale Sep 25, 2025
50c0449
fix lint issue
cx-sumit-morchhale Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions internal/wrappers/github-http.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@ import (
"fmt"
"io"
"net/http"
"strconv"
"strings"
"time"

"github.com/checkmarx/ast-cli/internal/logger"
"github.com/checkmarx/ast-cli/internal/params"
Expand Down Expand Up @@ -248,6 +250,10 @@ func get(client *http.Client, url string, target interface{}, queryParams map[st
if err != nil {
return nil, err
}
resp, err = handleRateLimit(resp, client, req, url, token, queryParams)
if err != nil {
return nil, err
}
defer func() {
if err == nil {
_ = resp.Body.Close()
Expand Down Expand Up @@ -276,3 +282,23 @@ func get(client *http.Client, url string, target interface{}, queryParams map[st
}
return resp, nil
}

func handleRateLimit(resp *http.Response, client *http.Client, req *http.Request, url, token string, queryParams map[string]string) (*http.Response, error) {
if resp.StatusCode == http.StatusForbidden {
remaining := resp.Header.Get("X-RateLimit-Remaining")
reset := resp.Header.Get("X-RateLimit-Reset")
if remaining == "0" && reset != "" {
resetUnix, err := strconv.ParseInt(reset, 10, 64)
if err == nil {
waitDuration := time.Until(time.Unix(resetUnix, 0))
if waitDuration > 0 {
time.Sleep(waitDuration)
return GetWithQueryParamsAndCustomRequest(client, req, url, token, tokenFormat, queryParams) // Indicate to retry
}
} else {
return resp, err
}
}
}
return resp, nil // Not rate limited
}
Loading