Skip to content

Conversation

@idlsoft
Copy link

@idlsoft idlsoft commented Feb 3, 2025

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

In a large monorepo it's useful to only analyze a specific subdirectory

References

Include supporting link to GitHub Issue/PR number

Testing

Describe how this change was tested. Be specific about anything not tested and reasons why. If this solution has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable).
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

@idlsoft idlsoft requested a review from cx-ben-alvo as a code owner February 3, 2025 19:41
default: ${{ github.repository_owner }}
description: "Organization name to create the Pr comment"
pr_number:
required: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks really good! the only thing missing now is adding an integration test to test the new behaviour :)
u can see our ci integration tests under file .github/workflows/ci.yml.
pls add the new test and we can move forward :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants