Skip to content

Show gutter icon only on first line of multi-line ignored secrets (AST-128760) #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cx-rahul-pidde merged 3 commits into from
Jan 19, 2026
Merged

Show gutter icon only on first line of multi-line ignored secrets (AST-128760) #1345

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe3e69c
fixed issue that show ignore icon on multiple line
cx-rahul-pidde Jan 7, 2026
732840b
fixed oauth mcp issue
cx-rahul-pidde Jan 8, 2026
c1afdd1
Merge branch 'main' into bug/AST-128760
cx-rahul-pidde Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/realtimeScanners/scanners/secrets/secretsScannerService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,23 +133,27 @@ export class SecretsScannerService extends BaseScannerService {
const key = `${entry.PackageName}:${entry.secretValue}:${relativePath}`;
const lines = secretLocations.get(key) || [];

lines.forEach(line => {
const adjustedLine = line;
// Only show gutter icon on the first line of multi-line secrets
if (lines.length > 0) {
const firstLine = lines[0];
const range = new vscode.Range(
new vscode.Position(adjustedLine, 0),
new vscode.Position(adjustedLine, 1000)
new vscode.Position(firstLine, 0),
new vscode.Position(firstLine, 1000)
);
ignoredDecorations.push({ range });
}

const hoverKey = `${filePath}:${adjustedLine}`;
// But keep hover data for all lines so users can hover anywhere
lines.forEach(line => {
const hoverKey = `${filePath}:${line}`;
if (!this.secretsHoverData.has(hoverKey)) {
this.secretsHoverData.set(hoverKey, {
title: entry.PackageName,
description: entry.description,
severity: entry.severity,
secretValue: entry.secretValue,
filePath,
location: { line: adjustedLine, startIndex: 0, endIndex: 1000 }
location: { line: line, startIndex: 0, endIndex: 1000 }
});
}
});
Expand Down
Loading