Skip to content

fix(analyzer): add failed utf conversions to unwanted files#7985

Closed
cx-miguel-dasilva wants to merge 3 commits intomasterfrom
AST-128677
Closed

fix(analyzer): add failed utf conversions to unwanted files#7985
cx-miguel-dasilva wants to merge 3 commits intomasterfrom
AST-128677

Conversation

@cx-miguel-dasilva
Copy link
Collaborator

Reason for Proposed Changes

  • files that failed to convert to utf during the analysis process were not being added to unwantad path, and then they would be picked up during getSources of supported parsers, if other platform types were identified.

Proposed Changes

  • add failed conversion to unwanted files
  • add unit test
  • add e2e test

I submit this contribution under the Apache-2.0 license.

@cx-miguel-dasilva cx-miguel-dasilva self-assigned this Mar 6, 2026
@cx-miguel-dasilva cx-miguel-dasilva requested a review from a team as a code owner March 6, 2026 13:17
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

kics-logo

KICS version: v2.1.18

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 47
Queries failed to execute placeholder 0
Execution time placeholder 0

cx-bruno-silva
cx-bruno-silva previously approved these changes Mar 6, 2026
Copy link
Contributor

@cx-bruno-silva cx-bruno-silva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cx-artur-ribeiro cx-artur-ribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch Miguel, great test additions as well.
Approved! 🥳

@cx-miguel-dasilva cx-miguel-dasilva deleted the AST-128677 branch March 13, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants