Skip to content

Breaking: Rename authentication variables #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
robin-checkmk wants to merge 3 commits into
base: devel
Choose a base branch
from
Open

Breaking: Rename authentication variables #941

robin-checkmk wants to merge 3 commits into from

Conversation

@robin-checkmk
Copy link
Member

@robin-checkmk robin-checkmk commented Nov 25, 2025 •
edited
Loading

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue: #905

The authentication variables used in the collection have intentionally diverted, as we realized good naming of these variables needs a different approach than what was done in the early days of the collection.

With #852 we introduced two new authentication-related variables: api_auth_type and api_auth_cookie. We prefixed them with api_, as that is what they relate to: The Checkmk REST API.

From the early days of the collection, we used automation_user and automation_secret for authentication against Checkmk. But again, these two variables define how we authenticate against the Checkmk REST API.

What is the new behavior?

With this pull request, we re-align all authentication-related variables and make them consistently use the api_ prefix.

Other information

@robin-checkmk robin-checkmk self-assigned this Nov 25, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation role:server This affects the server role role:agent This affects the agent role module:activation This affects the activation module module:contact_group This affects the contact_group module module:discovery This affects the discovery module module:downtime This affects the downtime module module:folder This affects the folder module module:host_group This affects the host_group module module:host This affects the host module module:rule This affects the rule module module:service_group This affects the service_group module module:tag_group This affects the tag_group module module:user This affects the user module module:bakery This affects the bakery module module:timeperiod This affects the timeperiod module module:password This affects the password module module:site This affects the site module inventory module:dcd This affects the dcd module. labels Nov 25, 2025
@robin-checkmk robin-checkmk force-pushed the breaking/rename-auth-options branch 3 times, most recently from e83c50e to dfbbc30 Compare December 29, 2025 10:30
@github-actions github-actions bot added the module:aux_tag This affects the 'aux_tag' module. label Dec 29, 2025
@robin-checkmk robin-checkmk force-pushed the breaking/rename-auth-options branch from dfbbc30 to e5cce02 Compare December 29, 2025 13:18
@robin-checkmk robin-checkmk force-pushed the breaking/rename-auth-options branch from e5cce02 to 0b026bc Compare December 29, 2025 16:17
@robin-checkmk robin-checkmk marked this pull request as ready for review December 29, 2025 16:18
@robin-checkmk robin-checkmk changed the title WIP: Breaking: Rename authentication variables Breaking: Rename authentication variables Dec 30, 2025
kumaran-repo
kumaran-repo reviewed Dec 30, 2025
View reviewed changes
@robin-checkmk robin-checkmk force-pushed the breaking/rename-auth-options branch from 0b026bc to 2ada561 Compare December 30, 2025 11:16
@robin-checkmk robin-checkmk linked an issue Dec 30, 2025 that may be closed by this pull request
[FEED] Rename authentication variables #905
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaran-repo kumaran-repo kumaran-repo left review comments

@lgetwan lgetwan Awaiting requested review from lgetwan lgetwan is a code owner

@nico-checkmk nico-checkmk Awaiting requested review from nico-checkmk

@Max-checkmk Max-checkmk Awaiting requested review from Max-checkmk Max-checkmk is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@robin-checkmk robin-checkmk

Labels

documentation Improvements or additions to documentation inventory module:activation This affects the activation module module:aux_tag This affects the 'aux_tag' module. module:bakery This affects the bakery module module:contact_group This affects the contact_group module module:dcd This affects the dcd module. module:discovery This affects the discovery module module:downtime This affects the downtime module module:folder This affects the folder module module:host_group This affects the host_group module module:host This affects the host module module:password This affects the password module module:rule This affects the rule module module:service_group This affects the service_group module module:site This affects the site module module:tag_group This affects the tag_group module module:timeperiod This affects the timeperiod module module:user This affects the user module role:agent This affects the agent role role:server This affects the server role

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEED] Rename authentication variables

3 participants

@robin-checkmk @kumaran-repo