Skip to content

Conversation

@robin-checkmk
Copy link
Member

@robin-checkmk robin-checkmk commented Jan 2, 2026

Pull request type

Try to limit your pull request to one type, submit multiple pull requests if needed.

Check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (describe what kind of change you performed):

What is the current behavior?

There are several lookup plugins who exist twice for good reason.
Currently, we have integration tests for every single one of them.
To me, it makes sense to simplify this and have one integration test per set.
This reduces overall complexity and overhead significantly, while the risk of having flaky tests or false positives is rather small.

What is the new behavior?

Integration tests now are combined for lookup module "pairs".
While merging the existing tests, improvements to the overall test logic were implemented as well.
The testing scope should at least be the same as before, potentially better.

Other information

Once this has been merged into main, we can also remove duplicate labels. Check the changed files for the auto labelers.

ToDo: Can we improve the tests lookup_rules and lookup_rulesets as well, or are they fine as they are?

@robin-checkmk robin-checkmk self-assigned this Jan 2, 2026
@robin-checkmk robin-checkmk force-pushed the build/simplify-lookup-tests branch 2 times, most recently from f00f0ed to 5a557d4 Compare January 2, 2026 16:31
Base automatically changed from build/improve-env-var-testing to devel January 5, 2026 12:45
@robin-checkmk robin-checkmk force-pushed the build/simplify-lookup-tests branch from 5a557d4 to 05ea7b5 Compare January 5, 2026 13:05
@robin-checkmk robin-checkmk force-pushed the build/simplify-lookup-tests branch from 05ea7b5 to 0031d12 Compare January 5, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants