WIP: Simplify integration tests for lookup plugins #977
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Check the type of change your PR introduces:
What is the current behavior?
There are several lookup plugins who exist twice for good reason.
Currently, we have integration tests for every single one of them.
To me, it makes sense to simplify this and have one integration test per set.
This reduces overall complexity and overhead significantly, while the risk of having flaky tests or false positives is rather small.
What is the new behavior?
Integration tests now are combined for lookup module "pairs".
While merging the existing tests, improvements to the overall test logic were implemented as well.
The testing scope should at least be the same as before, potentially better.
Other information
Once this has been merged into
main, we can also remove duplicate labels. Check the changed files for the auto labelers.ToDo: Can we improve the tests
lookup_rulesandlookup_rulesetsas well, or are they fine as they are?