Feature support Valkey #860
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General information
Because of a former license change some linux distributions migrate from redis to its fork valkey (e.g. SLES 15 SP7 does not contain redis anymore. It was replaced with valkey). Same as the MySQL plugin also supports its fork MariaDB the redis plugin should support Valkey.
mk_redis already works with Valkey if configured explicitly and either redis-cli is present or is a symlink to valkey-cli.
Proposed changes
Use the mk_redis plugin to detect valkey-server instances and auto-detect the available cli.
This requires two modifications:
As a bonus this PR moves the special case for the redis-cli of a CheckMK site also into the redis_args function. So configuration of REDIS_CLI_COMMAND is all in one place.