Skip to content

Add pci slot as unique key to vga card inventory #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add pci slot as unique key to vga card inventory #861

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions cmk/plugins/collection/agent_based/inventory_lnx_video.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@

@dataclass
class GraphicsCard:
slot: str
name: str
subsystem: str | None = None
driver: str | None = None
Expand All @@ -46,14 +47,15 @@ def parse_lnx_video(string_table: StringTable) -> Section:
continue

if "VGA compatible controller" in line[-2]:
current_slot = ":".join(line).split()[0]
current_name = line[-1].strip()
if current_name:
parsed_section.setdefault(current_name, GraphicsCard(name=current_name))
parsed_section.setdefault(current_slot, GraphicsCard(slot=current_slot, name=current_name))
elif current_name:
if line[0] == "Subsystem":
parsed_section[current_name].subsystem = line[1].strip()
parsed_section[current_slot].subsystem = line[1].strip()
elif line[0] == "Kernel driver in use":
parsed_section[current_name].driver = line[1].strip()
parsed_section[current_slot].driver = line[1].strip()

return parsed_section

Expand All @@ -70,9 +72,10 @@ def inventory_lnx_video(section: Section) -> InventoryResult:
yield TableRow(
path=["hardware", "video"],
key_columns={
"name": graphics_card.name,
"slot": graphics_card.slot,
},
inventory_columns={
"name": graphics_card.name,
"subsystem": graphics_card.subsystem,
"driver": graphics_card.driver,
},
Expand Down
Loading