Skip to content

Prevent crash in agent_proxmox_ve special agent when backup log fetch fails #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −1
Open

Prevent crash in agent_proxmox_ve special agent when backup log fetch fails #864

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion cmk/plugins/proxmox_ve/special_agent/agent_proxmox_ve.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,17 @@ def agent_proxmox_ve_main(args: Args) -> int:
)

LOGGER.info("Fetch and process backup logs..")
logged_backup_data = fetch_backup_data(args, session, data["nodes"])
logged_backup_data = {}

for node in data["nodes"]:
try:
node_backups = fetch_backup_data(args, session, [node])
if not node_backups:
LOGGER.info(f"No backups found for any VMs on node {node}")
else:
logged_backup_data.update(node_backups)
except Exception as e:
LOGGER.warning(f"Could not fetch backup logs for node {node} due to: {e}")

all_vms = {
str(entry["vmid"]): entry
Expand Down
Loading