-
Notifications
You must be signed in to change notification settings - Fork 183
feat: add tablet-optimized sidebar navigation with responsive layout support #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chengcheng84
wants to merge
15
commits into
CherryHQ:main
Choose a base branch
from
chengcheng84:feat/tablet-responsive-sidebar
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: add tablet-optimized sidebar navigation with responsive layout support #306
chengcheng84
wants to merge
15
commits into
CherryHQ:main
from
chengcheng84:feat/tablet-responsive-sidebar
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update various settings screens to use ScrollView with padding instead of Container for better scrolling behavior and consistent layout. Also adjust drawer handling in McpScreen to use custom hook.
Introduce a new dropdown in general settings to select tablet sidebar position (left/right). Includes new icons, preference schema updates, and UI component.
Introduce a responsive layout for tablets in landscape mode with a persistent sidebar. The sidebar contains navigation elements and assistant list. Mobile and portrait layouts remain unchanged with drawer navigation. Added useDrawer hook to centralize drawer logic.
Add cleanup for navigation ref to prevent memory leaks Replace useMemo with direct computation in useResponsive hook Update navigationRef to use mutable ref object
Update various settings screens to use ScrollView with padding instead of Container for better scrolling behavior and consistent layout. Also adjust drawer handling in McpScreen to use custom hook.
Introduce a new dropdown in general settings to select tablet sidebar position (left/right). Includes new icons, preference schema updates, and UI component.
Introduce a responsive layout for tablets in landscape mode with a persistent sidebar. The sidebar contains navigation elements and assistant list. Mobile and portrait layouts remain unchanged with drawer navigation. Added useDrawer hook to centralize drawer logic.
Add cleanup for navigation ref to prevent memory leaks Replace useMemo with direct computation in useResponsive hook Update navigationRef to use mutable ref object
…hengcheng84/cherry-studio-app into feat/tablet-responsive-sidebar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
平板设备侧边栏


