Draft
Conversation
Add SQLite schema and TypeScript types for the knowledge module migration from Redux/Dexie to the v2 Data API architecture: - Add knowledge_base and knowledge_item table schemas with proper indexes - Add KnowledgeItemData discriminated union types for type-safe item data - Add FileMetadata type to shared package - Include design documentation for the migration approach 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
0xfullex
reviewed
Jan 7, 2026
Collaborator
|
Note This comment was translated by Claude.
knowledgeBase table
knowledgeItem table
Original Content
knowledgeBase表
knowledageItem表
|
Collaborator
|
Note This comment was translated by Claude. Isn't this PR about migrating the vectorstore? Original Content迁移vectorstore是这个PR不 |
Collaborator
Author
|
Note This comment was translated by Claude. @0xfullex Updated
knowledge_base table:
knowledge_item table:
Original Content@0xfullex 已修改
knowledge_base 表:
knowledge_item 表:
|
Collaborator
Author
- Replace `store.getState().knowledge.bases` with `dataApiService.get('/knowledge-bases')`
- Replace `window.api.knowledgeBase.search/rerank` with `dataApiService.get('/knowledge-bases/:id/search')`
- Move threshold filtering and documentCount limiting from renderer to KnowledgeBaseService (server-side)
- Add `threshold` and `documentCount` params to KnowledgeSearchRequest schema
- Remove unused imports (DEFAULT_KNOWLEDGE_DOCUMENT_COUNT, estimateTextTokens)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
任务进度