Skip to content

Conversation

@SherlockShemol
Copy link
Contributor

What this PR does

Before this PR:

  • Settings pages used antd Input and TextArea components
  • Inline styles like style={{ width: 180 }}

After this PR:

  • Migrated to @cherrystudio/ui Input and Textarea components
  • Uses Tailwind CSS classes instead of inline styles

Why we need it and why it was done in this way

Part of the ongoing v2 migration from antd to Shadcn UI. These are simple, self-contained changes in 4 settings files.

The following tradeoffs were made:

  • None, straightforward component replacement

The following alternatives were considered:

  • N/A

Breaking changes

None. The components have compatible APIs.

Checklist

  • PR: The PR description is expressive enough and will help future contributors
  • Code: Write code that humans can understand and Keep it simple
  • Refactor: Left the code cleaner than found (consolidated imports, removed antd dependency from these files)

Release note

NONE

Migrate Input and TextArea from antd to @cherrystudio/ui in settings pages:
- NameSetting, DescriptionSetting (AgentSettings)
- LocalBackupSettings (DataSettings)
- GeneralSettings

Also convert inline styles to Tailwind CSS classes.

Signed-off-by: SherlockShemol <[email protected]>
@SherlockShemol SherlockShemol requested a review from a team January 19, 2026 10:03
@DeJeune DeJeune added the v2 label Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants