Open
Conversation
Contributor
Author
|
这个 PR 改动只有关于 TODO 的注释 |
Contributor
|
我猜这个是给contributor留的todo吧?让他们把包名改成自己的 |
Contributor
Author
感谢回复!关于这个TODO注释,我想从几个角度补充一下:
所以,我认为这个TODO注释现在已经没有存在的必要,移除它能避免让其他开发者产生困惑(比如误以为还有未完成的配置)。当然,如果项目确实希望保留某种提示,建议用文档而非TODO来实现。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
style(android): 清理 defaultConfig TODO 注释
移除无价值 TODO 注释 · 仅注释清理 · 构建行为不变
Style
否
1
▱▱▱▱▱▱▱▱▱▱+0
-1核心目标
审阅指引
验证清单
构建验证(可选)
预期:构建通过;产物行为不变
本 PR 由 XiaoBuHaly:chore/TODO-remove-1 发起