feat: add desktop minimap search and refine popover transitions#446
Open
luosc wants to merge 1 commit intoChevey339:masterfrom
Open
feat: add desktop minimap search and refine popover transitions#446luosc wants to merge 1 commit intoChevey339:masterfrom
luosc wants to merge 1 commit intoChevey339:masterfrom
Conversation
Bring desktop minimap behavior in line with mobile by adding in-popover conversation search for desktop chat. Increase the popover height to leave room for the new search UI, preserve the existing message-pair filtering and selection behavior, and smooth the header interaction so the title fades out while the search field expands from the right and pushes the scroll-to-bottom button left more naturally. Closes Chevey339#445 File changes: - lib/desktop/mini_map_popover.dart: add desktop minimap search state, query filtering, taller adaptive popover sizing, and smoother right-anchored header transitions - test/desktop_mini_map_popover_test.dart: add widget coverage for search filtering and restoring the full message list after closing search
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring desktop minimap behavior in line with mobile by adding in-popover conversation search for desktop chat.
Increase the popover height to leave room for the new search UI, preserve the existing message-pair filtering and selection behavior, and smooth the header interaction so the title fades out while the search field expands from the right and pushes the scroll-to-bottom button left more naturally.
Closes #445
File changes: