-
Notifications
You must be signed in to change notification settings - Fork 5
mpi extension changes #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 5 commits
32736ca
2f2125e
5b04697
48fb06f
09a9f0d
4742906
a3b4ae1
8e84755
063cbd8
65999a6
5bf3beb
bbb8c56
8a5e168
1bcee1b
5a288a0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,12 +16,20 @@ jobs: | |
| - 1 # automatically expands to the latest stable 1.x release of Julia | ||
| devitoversion: | ||
| - 'main' | ||
| - 'devitopro' | ||
| # - 'devitopro' | ||
| - '' | ||
| os: | ||
| - ubuntu-latest | ||
| arch: | ||
| - x64 | ||
|
|
||
| env: | ||
| DEVITO_LANGUAGE: "openmp" | ||
| DEVITO_ARCH: "gcc" | ||
| OMP_NUM_THREADS: "2" | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should we get the number of threads with a function call?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what is the function call that you have in mind? Do you mean using the openmp c api?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Github runners are fixed 4-core config, so that's bit overkill to go through the trouble of infering it |
||
| DEVITO_AUTOPADDING: "0" | ||
| RDMAV_FORK_SAFE: 1 | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: julia-actions/setup-julia@v2 | ||
|
|
@@ -30,43 +38,48 @@ jobs: | |
| arch: ${{ matrix.arch }} | ||
| - uses: julia-actions/cache@v1 | ||
|
|
||
| - name: install mpi | ||
| run: sudo apt-get update | ||
| - run: sudo apt-get install -y mpich libmpich-dev | ||
| - name: Setup MPI | ||
| uses: mpi4py/setup-mpi@v1 | ||
| with: | ||
| mpi: 'mpich' | ||
|
|
||
| - name: download miniconda manually | ||
| run: wget https://repo.anaconda.com/miniconda/Miniconda3-py312_24.5.0-0-Linux-x86_64.sh | ||
|
|
||
| - name: run install | ||
| run: bash Miniconda3-py312_24.5.0-0-Linux-x86_64.sh -b -p $HOME/miniconda | ||
|
|
||
| - name: run path export | ||
| run: | | ||
| echo "$HOME/miniconda/bin:" >> $GITHUB_PATH | ||
| echo "PYTHON=$HOME/miniconda/bin/python3" >> $GITHUB_ENV | ||
| echo "PYCALL_JL_RUNTIME_PYTHON=$HOME/miniconda/bin/python3" >> $GITHUB_ENV | ||
| echo "CONDA_EXE=$HOME/miniconda/bin/conda" >> $GITHUB_ENV | ||
|
|
||
| - name: use system MPI | ||
| run: julia -e 'using Pkg; Pkg.add(["MPI", "MPIPreferences"]); using MPIPreferences; MPIPreferences.use_system_binary()' | ||
|
|
||
| - name: run build for devito/devitopro | ||
| if: matrix.devitoversion == 'devitopro' | ||
| run: julia --color=yes --project -e 'using Pkg; Pkg.build(verbose=true)' | ||
| env: | ||
| DEVITO_PRO: ${{ secrets.DEVITOPRO }} | ||
|
|
||
| - name: run build for devito | ||
| if: ! matrix.devitoversion != 'devitopro' | ||
| run: julia --color=yes --project -e 'using Pkg; Pkg.build(verbose=true)' | ||
| env: | ||
| DEVITO_BRANCH: ${{ matrix.devitoversion }} | ||
|
|
||
|
|
||
| - name: use system MPI | ||
| run: | | ||
| # https://juliaparallel.org/MPI.jl/latest/configuration/#Configuration-of-the-MPI.jl-testsuite | ||
| julia --project=test -e 'using Pkg; Pkg.instantiate(); Pkg.status(); using MPIPreferences; MPIPreferences.use_system_binary()' | ||
|
|
||
| # note Pkg.test docs indicate --inline=no can improve coverage | ||
| - run: julia --color=yes --check-bounds=yes --inline=no --project -e 'using Pkg; Pkg.test(coverage=true)' | ||
|
|
||
| - name: run tests | ||
| run: | | ||
| julia --color=yes --check-bounds=yes --inline=no --project -e 'using Pkg; Pkg.test(coverage=true)' | ||
|
|
||
| - uses: julia-actions/julia-processcoverage@v1 | ||
|
|
||
| - uses: codecov/codecov-action@v1 | ||
| with: | ||
| file: lcov.info | ||
|
|
@@ -79,29 +92,29 @@ jobs: | |
| - uses: julia-actions/setup-julia@v2 | ||
| with: | ||
| version: '1' | ||
|
|
||
| - name: install mpi | ||
| run: sudo apt-get update | ||
| - run: sudo apt-get install -y mpich | ||
|
|
||
| - name: download miniconda manually | ||
| run: wget https://repo.anaconda.com/miniconda/Miniconda3-py312_24.5.0-0-Linux-x86_64.sh | ||
|
|
||
| - name: run install | ||
| run: bash Miniconda3-py312_24.5.0-0-Linux-x86_64.sh -b -p ~/miniconda | ||
|
|
||
| - name: run path export | ||
| run: | | ||
| echo "$HOME/miniconda/bin:" >> $GITHUB_PATH | ||
| echo "PYTHON=$HOME/miniconda/bin/python3" >> $GITHUB_ENV | ||
| echo "PYCALL_JL_RUNTIME_PYTHON=$HOME/miniconda/bin/python3" >> $GITHUB_ENV | ||
| echo "CONDA_EXE=$HOME/miniconda/bin/conda" >> $GITHUB_ENV | ||
|
|
||
| - run: julia --color=yes --project -e 'using Pkg; if VERSION >= v"1.1.0-rc1"; Pkg.build(verbose=true); else Pkg.build(); end' | ||
| - run: julia --color=yes --project -e 'using Pkg; Pkg.build()' | ||
|
|
||
| - name: Install dependencies | ||
| run: julia --project=docs/ -e 'using Pkg; Pkg.develop(PackageSpec(path=pwd())); Pkg.instantiate()' | ||
|
|
||
| - run: | | ||
| julia --project=docs -e ' | ||
| using Pkg | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whats going on here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is related to credentials. let's chat offline about it.