Skip to content

Conversation

@nmbader
Copy link
Member

@nmbader nmbader commented Jul 30, 2025

Enable multithreading using Base.Threads in the 3D Bspline Jet operator jop_CubicSpline to improve performance.

@nmbader nmbader requested a review from samtkaplan July 30, 2025 14:57
@samtkaplan
Copy link
Member

Thanks! The way that you are adding the IterativeSolvers dep to the tests is incorrect. Instead, it should go in the test/Project.toml file. I think that is why the unit tests are failing. Let me know if you want me to push a commit to this branch to try and fix it.

@samtkaplan
Copy link
Member

btw, did this noticibly improve perf?

@nmbader
Copy link
Member Author

nmbader commented Aug 4, 2025

btw, did this noticibly improve perf?

I tried with JULIA_NUM_THREADS=44 on a sizable 3D problem and performance was more than 10x.

@nmbader
Copy link
Member Author

nmbader commented Aug 4, 2025

Thanks! The way that you are adding the IterativeSolvers dep to the tests is incorrect. Instead, it should go in the test/Project.toml file. I think that is why the unit tests are failing. Let me know if you want me to push a commit to this branch to try and fix it.

Thanks for pointing this out. I moved IterativeSolvers to test/Project.toml

@nmbader nmbader merged commit db2770b into master Aug 5, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants