Skip to content

Conversation

@altendky
Copy link
Contributor

@altendky altendky commented Jan 10, 2025

Add python 3.13 support.

Current status: complete and functional, but a flaky Windows pytest worker crash occurs approximately 20% of the time. The root cause remains unknown

Problems with 3.13 and Windows are "worked around" by using pytest-rerunfailures, which is able to detect when the pytest worker threads crash and can rerun the test.

Research should continue into why these worker crashes occur, but a complete resolution seems unlikely. Therefore, the current workaround, as implemented here, is proposed...

Draft For:

@altendky altendky requested a review from a team as a code owner January 10, 2025 22:17
@altendky altendky marked this pull request as draft January 10, 2025 22:19
@altendky altendky added the Added Required label for PR that categorizes merge commit message as "Added" for changelog label Jan 10, 2025
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jan 14, 2025
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2025

This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed by the relevant parties.

@github-actions github-actions bot added the stale-pr Flagged as stale and in need of manual review label Mar 1, 2025
@github-actions github-actions bot added merge_conflict Branch has conflicts that prevent merge to main and removed merge_conflict Branch has conflicts that prevent merge to main stale-pr Flagged as stale and in need of manual review labels Jul 11, 2025
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jul 16, 2025
@coveralls-official
Copy link

coveralls-official bot commented Jul 17, 2025

Pull Request Test Coverage Report for Build 17650086263

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 18 of 22 (81.82%) changed or added relevant lines in 2 files are covered.
  • 37 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.02%) to 91.242%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/server/chia_policy.py 13 14 92.86%
chia/_tests/core/server/test_event_loop.py 5 8 62.5%
Files with Coverage Reduction New Missed Lines %
chia/daemon/client.py 1 74.16%
chia/daemon/keychain_proxy.py 1 70.57%
chia/daemon/server.py 1 83.54%
chia/farmer/farmer.py 1 73.32%
chia/full_node/full_node.py 1 88.11%
chia/_tests/core/server/test_event_loop.py 1 89.04%
chia/server/node_discovery.py 2 82.65%
chia/timelord/timelord_launcher.py 2 90.71%
chia/rpc/rpc_server.py 3 88.4%
chia/full_node/full_node_api.py 5 85.6%
Totals Coverage Status
Change from base Build 17624749078: -0.02%
Covered Lines: 102848
Relevant Lines: 112584

💛 - Coveralls

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jul 21, 2025
@github-actions github-actions bot added merge_conflict Branch has conflicts that prevent merge to main and removed merge_conflict Branch has conflicts that prevent merge to main labels Jul 30, 2025
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Aug 5, 2025
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Aug 13, 2025
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Aug 18, 2025
@wallentx
Copy link
Contributor

@socket-security
Copy link

socket-security bot commented Oct 21, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedpypi/​pytest-rerunfailures@​16.110010010010070

View full report

@emlowe emlowe marked this pull request as ready for review October 22, 2025 16:01
hoffmang9
hoffmang9 previously approved these changes Oct 22, 2025
Quexington
Quexington previously approved these changes Oct 22, 2025
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Oct 22, 2025
@emlowe emlowe dismissed stale reviews from Quexington and hoffmang9 via a49bdf9 October 22, 2025 17:11
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Oct 22, 2025
emlowe
emlowe previously approved these changes Oct 22, 2025
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Oct 22, 2025
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Oct 23, 2025
@github-actions
Copy link
Contributor

File Coverage Missing Lines
chia/__init__.py 66.7% lines 21
chia/_tests/core/server/test_event_loop.py 62.5% lines 34, 110-111
chia/server/chia_policy.py 92.9% lines 199
Total Missing Coverage
25 lines 5 lines 80%

@cmmarslender cmmarslender merged commit e8f5a17 into main Oct 23, 2025
829 of 836 checks passed
@cmmarslender cmmarslender deleted the fine_william___fine branch October 23, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Added Required label for PR that categorizes merge commit message as "Added" for changelog community-pr

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants