Skip to content

Conversation

AmineKhaldi
Copy link
Contributor

@AmineKhaldi AmineKhaldi commented Jun 13, 2025

Purpose:

Introduce a new state for the spent_index column in the coin_record table to track unspent coins that have the same puzzle hash and amount as their parents.

Current Behavior:

spent_index = 0 means a coin is unspent.

New Behavior:

spent_index = 0 means a regular coin is unspent, and spent_index = -1 means this unspent coin has the same puzzle hash and amount as its parent.

@AmineKhaldi AmineKhaldi self-assigned this Jun 13, 2025
@AmineKhaldi AmineKhaldi added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Jun 13, 2025
Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have a plan for how to handle coins created before this change too

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jun 16, 2025
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@AmineKhaldi AmineKhaldi force-pushed the fast_forward_mempool_optimization branch from eba747d to b63b4f2 Compare June 17, 2025 15:01
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jun 17, 2025
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@AmineKhaldi AmineKhaldi force-pushed the fast_forward_mempool_optimization branch from b63b4f2 to 3d2a631 Compare June 20, 2025 13:36
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jun 23, 2025
@AmineKhaldi AmineKhaldi force-pushed the fast_forward_mempool_optimization branch from 3d2a631 to 8439a25 Compare July 1, 2025 10:21
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jul 1, 2025
@AmineKhaldi AmineKhaldi marked this pull request as ready for review July 3, 2025 09:39
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner July 3, 2025 09:39
@arvidn
Copy link
Contributor

arvidn commented Jul 3, 2025

I don't expect that checking amount being odd is important. That's not going to bring a material speed-up (if one at a ll), right?

@AmineKhaldi AmineKhaldi force-pushed the fast_forward_mempool_optimization branch from 8439a25 to c739fd0 Compare July 7, 2025 18:25
arvidn
arvidn previously approved these changes Jul 8, 2025
@AmineKhaldi AmineKhaldi force-pushed the fast_forward_mempool_optimization branch from c739fd0 to 1383094 Compare July 9, 2025 09:54
Copy link

Pull Request Test Coverage Report for Build 16166185982

Details

  • 156 of 156 (100.0%) changed or added relevant lines in 5 files are covered.
  • 29 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.007%) to 91.395%

Files with Coverage Reduction New Missed Lines %
chia/full_node/pending_tx_cache.py 1 96.55%
chia/rpc/rpc_server.py 1 89.16%
chia/wallet/wallet_node.py 1 87.67%
chia/server/node_discovery.py 4 81.75%
chia/server/server.py 4 82.51%
chia/server/address_manager.py 5 92.84%
chia/full_node/full_node.py 13 87.78%
Totals Coverage Status
Change from base Build 16149582872: 0.007%
Covered Lines: 102197
Relevant Lines: 111693

💛 - Coveralls

@arvidn arvidn added the ready_to_merge Submitter and reviewers think this is ready label Jul 9, 2025
@cmmarslender cmmarslender merged commit c609d0b into Chia-Network:main Jul 10, 2025
345 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changed Required label for PR that categorizes merge commit message as "Changed" for changelog ready_to_merge Submitter and reviewers think this is ready

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants