Skip to content

[CHIA-3251] Delete DID recovery endpoints #19767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jul 18, 2025
Merged

[CHIA-3251] Delete DID recovery endpoints #19767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
df69d82
Port `did_set_wallet_name`
Quexington Jun 12, 2025
ad60a68
Port `did_get_wallet_name`
Quexington Jun 12, 2025
9d712aa
Port `did_update_recovery_ids`
Quexington Jun 12, 2025
11fcdd6
Port `did_message_spend`
Quexington Jun 12, 2025
b388478
Port `did_get_info`
Quexington Jun 24, 2025
7e4c1bc
Port `did_find_lost_did`
Quexington Jun 24, 2025
d7f2154
fix test
Quexington Jun 24, 2025
dd2eea0
Port `did_update_metadata`
Quexington Jun 25, 2025
23718e2
Port `did_get_did`
Quexington Jun 25, 2025
a1b2cdf
Port `did_get_recovery_list`
Quexington Jun 25, 2025
697ff1d
Port `did_get_metadata`
Quexington Jun 25, 2025
0f3b8b9
Port `did_get_pubkey`
Quexington Jun 25, 2025
c64b20e
Port `did_get_information_needed_for_recovery`
Quexington Jun 25, 2025
e92860b
Port `did_get_current_coin_info`
Quexington Jun 26, 2025
62a39ff
Port `did_create_backup_file`
Quexington Jun 26, 2025
ae3c707
Port `did_transfer_did`
Quexington Jun 26, 2025
50f43f8
Add extra_conditions uniformly in CLI tests
Quexington Jun 26, 2025
29bf5c0
test coverage
Quexington Jun 26, 2025
69e29ad
Delete DID recovery endpoints
Quexington Jun 26, 2025
e1fd836
Delete `create_exit_spend` as well
Quexington Jun 26, 2025
4984ab4
Missed one
Quexington Jun 27, 2025
e522450
Merge remote-tracking branch 'origin/main' into quex.delete_did_recov…
Quexington Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,322 changes: 105 additions & 1,217 deletions chia/_tests/wallet/did_wallet/test_did.py
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion chia/_tests/wallet/nft_wallet/test_nft_wallet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1284,7 +1284,7 @@ async def test_nft_transfer_nft_with_did(wallet_environments: WalletTestFramewor
async with did_wallet.wallet_state_manager.new_action_scope(
wallet_environments.tx_config, push=True
) as action_scope:
await did_wallet.transfer_did(wallet_1_ph, uint64(0), True, action_scope)
await did_wallet.transfer_did(wallet_1_ph, uint64(0), action_scope)

await wallet_environments.process_pending_states(
[
Expand Down
16 changes: 0 additions & 16 deletions chia/_tests/wallet/rpc/test_wallet_rpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,13 +111,11 @@
DIDGetDID,
DIDGetMetadata,
DIDGetPubkey,
DIDGetRecoveryList,
DIDGetWalletName,
DIDMessageSpend,
DIDSetWalletName,
DIDTransferDID,
DIDUpdateMetadata,
DIDUpdateRecoveryIDs,
FungibleAsset,
GetNotifications,
GetPrivateKey,
Expand Down Expand Up @@ -1538,20 +1536,6 @@ async def test_did_endpoints(wallet_rpc_environment: WalletRpcTestEnvironment) -
# Create backup file
await wallet_1_rpc.create_did_backup_file(DIDCreateBackupFile(did_wallet_id_0))

await time_out_assert(5, check_mempool_spend_count, True, full_node_api, 1)
await farm_transaction_block(full_node_api, wallet_1_node)
# Update recovery list
update_res = await wallet_1_rpc.update_did_recovery_list(
DIDUpdateRecoveryIDs(
wallet_id=uint32(did_wallet_id_0), new_list=[did_id_0], num_verifications_required=uint64(1), push=True
),
DEFAULT_TX_CONFIG,
)
assert len(update_res.transactions) > 0
recovery_list_res = await wallet_1_rpc.get_did_recovery_list(DIDGetRecoveryList(did_wallet_id_0))
assert recovery_list_res.num_required == 1
assert recovery_list_res.recovery_list[0] == did_id_0

await time_out_assert(5, check_mempool_spend_count, True, full_node_api, 1)
await farm_transaction_block(full_node_api, wallet_1_node)

Expand Down
2 changes: 1 addition & 1 deletion chia/_tests/wallet/vc_wallet/test_vc_wallet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,7 +753,7 @@ async def test_self_revoke(wallet_environments: WalletTestFramework) -> None:
async with did_wallet.wallet_state_manager.new_action_scope(
wallet_environments.tx_config, push=True
) as action_scope:
await did_wallet.transfer_did(bytes32.zeros, uint64(0), False, action_scope)
await did_wallet.transfer_did(bytes32.zeros, uint64(0), action_scope)

await wallet_environments.process_pending_states(
[
Expand Down
Loading
Loading