-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Change shebangs from python3 to python #19786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
need to test on my macbook. |
still works on my macbook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this might be a reasonable solution. i'm trying to understand the situation a bit more still.
to document, the hassle here is that we have direct shebang usage on linux/macos and handling the variety there. we then have windows configurations allowing for associating |
This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed by the relevant parties. |
Purpose:
Allows these files to run on windows
Current Behavior:
Pre-commit broken on windows
New Behavior:
Pre-commit working on windows
Testing Notes:
Change python3 to python in shebang in all files