Skip to content

Conversation

altendky
Copy link
Contributor

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

@altendky altendky added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels Jul 10, 2025
@altendky altendky requested a review from a team as a code owner July 10, 2025 01:07
@altendky altendky added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels Jul 10, 2025
@altendky altendky mentioned this pull request Jul 10, 2025
Copy link

coveralls-official bot commented Jul 10, 2025

Pull Request Test Coverage Report for Build 16270382397

Details

  • 3 of 6 (50.0%) changed or added relevant lines in 3 files are covered.
  • 16 unchanged lines in 8 files lost coverage.
  • Overall coverage remained the same at 91.36%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/wallet/cat_wallet/cat_wallet.py 1 2 50.0%
chia/wallet/cat_wallet/r_cat_wallet.py 1 2 50.0%
chia/wallet/vc_wallet/cr_cat_wallet.py 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
chia/daemon/server.py 1 84.4%
chia/server/node_discovery.py 1 80.32%
chia/_tests/core/util/test_lockfile.py 1 88.43%
chia/timelord/timelord_launcher.py 2 90.71%
chia/util/files.py 2 91.38%
chia/wallet/wallet_node.py 2 87.45%
chia/rpc/rpc_server.py 3 88.24%
chia/server/server.py 4 82.51%
Totals Coverage Status
Change from base Build 16268760702: 0.0%
Covered Lines: 102392
Relevant Lines: 111954

💛 - Coveralls

aqk
aqk previously approved these changes Jul 10, 2025
Copy link
Contributor

File Coverage Missing Lines
chia/wallet/cat_wallet/cat_wallet.py 50.0% lines 262
chia/wallet/cat_wallet/r_cat_wallet.py 50.0% lines 145
chia/wallet/vc_wallet/cr_cat_wallet.py 50.0% lines 142
Total Missing Coverage
6 lines 3 lines 50%

@Starttoaster
Copy link
Contributor

Starttoaster commented Jul 14, 2025

@emlowe @altendky please make a determination from the reported coverage diff. Thank you :)

@Starttoaster Starttoaster merged commit ab9e729 into main Jul 14, 2025
688 of 692 checks passed
@Starttoaster Starttoaster deleted the fewer_mutable_defaults branch July 14, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants