[CHIA-2827] simplify MempoolManager by removing EligibilityAndAdditions

[arvidn]

Purpose:

This simplification is in preparation for another improvement to the mempool dedup feature.
We have the same list of CoinSpends in two different places, once in SpendBundle and once in the result from running the generator SpendBundleConditions. We need to merge the information from both of these (and ensure that they match each other).

Current Behavior:

While iterating over SpendBundleConditions, build a new dictionary mapping coin ID to EligibilityAndAdditions.
Then iterate over SpendBundle and perform lookups in the dictionary.

New Behavior:

Build a map of coin ID -> SpendCondition.
While iterating over SpendBundle, look up the corresponding condition from the map.
This moves all logic into a single loop.

[AmineKhaldi]

Looks good, left some suggestions.

[coveralls-official]

Pull Request Test Coverage Report for Build 16227671941

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 22 of 22 (100.0%) changed or added relevant lines in 2 files are covered.
• 198 unchanged lines in 22 files lost coverage.
• Overall coverage decreased (-0.06%) to 91.353%

---

Files with Coverage Reduction	New Missed Lines	%
chia/_tests/core/mempool/test_mempool_manager.py	1	99.93%
chia/_tests/wallet/cat_wallet/test_trades.py	1	99.8%
chia/wallet/cat_wallet/cat_outer_puzzle.py	1	98.81%
chia/wallet/nft_wallet/metadata_outer_puzzle.py	1	97.14%
chia/wallet/nft_wallet/singleton_outer_puzzle.py	1	98.77%
chia/_tests/wallet/cat_wallet/test_cat_wallet.py	2	99.58%
chia/wallet/vc_wallet/vc_drivers.py	2	99.23%
chia/wallet/nft_wallet/transfer_program_puzzle.py	3	88.89%
chia/full_node/weight_proof.py	4	90.6%
chia/_tests/core/full_node/test_full_node.py	4	98.48%

Totals
Change from base Build 16184231739:	-0.06%
Covered Lines:	102351
Relevant Lines:	111916

---

💛 - Coveralls

[wjblanke]

aok