Skip to content

Conversation

matt-o-how
Copy link
Contributor

@matt-o-how matt-o-how commented Jul 11, 2025

Purpose:

This PR removes a remaining dependency on Program in the full node API.
It also removes the SpendInfo class which was redundant, and the file mempool_check_conditions.py which was at best poorly named, and most likely entirely redundant when calls directly into chia_rs would do the same job.

Current Behavior:

Currently the full node API uses Program from clvm to run a Generator and parse it.
We want to separate Program into only being used in the wallet, so this code must change.

New Behavior:

We import from chia_rs and then parse the returned data into the previously expected format

Testing Notes:

@matt-o-how matt-o-how added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Jul 11, 2025
@matt-o-how matt-o-how marked this pull request as ready for review July 11, 2025 14:40
@matt-o-how matt-o-how requested a review from a team as a code owner July 11, 2025 14:40
@matt-o-how matt-o-how requested a review from arvidn July 11, 2025 14:41
Copy link

coveralls-official bot commented Jul 11, 2025

Pull Request Test Coverage Report for Build 16271069671

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 46 of 48 (95.83%) changed or added relevant lines in 8 files are covered.
  • 112 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.008%) to 91.339%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/full_node/full_node_rpc_api.py 9 11 81.82%
Files with Coverage Reduction New Missed Lines %
chia/rpc/rpc_server.py 1 88.24%
chia/_tests/core/mempool/test_mempool_manager.py 1 99.93%
chia/types/coin_spend.py 1 90.63%
chia/wallet/util/wallet_sync_utils.py 1 86.07%
chia/simulator/block_tools.py 3 98.15%
chia/wallet/wallet_node.py 4 87.53%
chia/full_node/eligible_coin_spends.py 6 95.71%
chia/util/network.py 7 92.13%
chia/cmds/peer_funcs.py 19 42.11%
chia/full_node/mempool_manager.py 19 97.02%
Totals Coverage Status
Change from base Build 16206121861: -0.008%
Covered Lines: 102316
Relevant Lines: 111899

💛 - Coveralls

@arvidn
Copy link
Contributor

arvidn commented Jul 12, 2025

I think this looks good. You should test these RPCs manually before we land it though

Copy link
Contributor

File Coverage Missing Lines
chia/full_node/full_node_rpc_api.py 81.8% lines 796-797
Total Missing Coverage
48 lines 2 lines 95%

@arvidn arvidn added ready_to_merge Submitter and reviewers think this is ready and removed coverage-diff labels Jul 15, 2025
@Starttoaster Starttoaster merged commit 9f8ba79 into main Jul 15, 2025
520 of 522 checks passed
@Starttoaster Starttoaster deleted the separate_clvm_from_full_node branch July 15, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changed Required label for PR that categorizes merge commit message as "Changed" for changelog ready_to_merge Submitter and reviewers think this is ready

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants