Skip to content

Conversation

wallentx
Copy link
Contributor

Purpose:

This PR improves the CI experience for external contributors by ensuring that jobs can run successfully on forks. It resolves an issue where many CI jobs would get stuck in a pending state indefinitely because they were configured to use self-hosted runners that are only available in the chia-network/chia-blockchain repository. This change allows contributors to get timely and accurate feedback from the CI system.

This PR does not introduce a breaking change.

Current Behavior:

Currently, several CI jobs are configured to use specific self-hosted runners (e.g., [Linux, ARM64], macos-13-arm64, benchmark). When a contributor creates a pull request on their fork, these jobs are triggered but can never be assigned to a runner, as the required self-hosted runners do not exist in their forked repository. This causes the jobs to remain in a "pending" state forever, providing no feedback and cluttering the pull request's checks.

New Behavior:

The workflows have been updated with conditional logic based on the repository owner (github.repository_owner).

  • If a workflow is running in the Chia-Network Organization, it will continue to use the specialized self-hosted runners as before.
  • If the workflow is running on a fork, it will now use appropriate, publicly available GitHub-hosted runners (e.g., ubuntu-22.04-arm, macos-latest).

This ensures that all CI jobs can run to completion on forks, providing contributors with the feedback they need.

Testing Notes:

Tested on my fork wallentx#19

@wallentx wallentx requested a review from a team as a code owner July 11, 2025 17:54
@cmmarslender cmmarslender added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels Jul 11, 2025
Copy link

coveralls-official bot commented Jul 11, 2025

Pull Request Test Coverage Report for Build 16351588853

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 570 unchanged lines in 32 files lost coverage.
  • Overall coverage increased (+0.04%) to 91.386%

Files with Coverage Reduction New Missed Lines %
chia/daemon/client.py 1 74.16%
chia/daemon/keychain_proxy.py 1 73.24%
chia/farmer/farmer.py 1 73.28%
chia/rpc/rpc_server.py 1 89.16%
chia/server/node_discovery.py 1 82.29%
chia/_tests/core/mempool/test_mempool_manager.py 1 99.93%
chia/_tests/util/spend_sim.py 1 95.77%
chia/_tests/wallet/rpc/test_wallet_rpc.py 1 99.69%
chia/wallet/util/wallet_sync_utils.py 1 86.07%
chia/farmer/farmer_api.py 2 94.36%
Totals Coverage Status
Change from base Build 16206121861: 0.04%
Covered Lines: 102392
Relevant Lines: 111929

💛 - Coveralls

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Aug 11, 2025
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Aug 12, 2025
Copy link
Member

@hoffmang9 hoffmang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Starttoaster Starttoaster merged commit 35291ee into Chia-Network:main Aug 14, 2025
683 of 686 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changed Required label for PR that categorizes merge commit message as "Changed" for changelog community-pr Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants