-
Notifications
You must be signed in to change notification settings - Fork 2.1k
use per-puzzle cost to estimate DEDUP savings #19811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 16573949364Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Due to the amount of review suggestions I sent an addendum (PR #19816) to take care of all of them.
…x_cost parameter from get_deduplication_info()
Addendum to use per-puzzle cost to estimate DEDUP savings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aok
Purpose:
The most recent
chia_rs
update included a feature whererun_block_generator2()
records the execution cost and condition cost per puzzle/spend. Use that cost inMempoolItem
to estimate the cost savings when deduplicating spends (in the dedup feature).Today we run the puzzle again in order to know the cost. This both simplifies and optimizes the DEDUP feature.
This is a step towards exploring using the "puzzle fingerprint" rather than solution bytes to compare equality of spends. i.e. to compare the condition outputs rather than the actual solution.
Current Behavior:
run_for_cost()
, per puzzle, to compute the per-puzzle cost. Used in dedup.New Behavior: