Upgrade ruff to 0.12.3 and fix trailing comma issues #19813
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades ruff from 0.11.11 to 0.12.3 and addresses the linting issues that arise with the newer version.
Changes Made
1. Updated Dependencies
pyproject.toml
to requireruff >= 0.12.3
2. Fixed Trailing Comma Issues (COM812)
The main issue with ruff 0.12.3 was the
missing-trailing-comma
rule (COM812) which was previously disabled due to 5000+ violations. This rule is commonly enabled in newer ruff versions to enforce consistent code style.ruff check --fix
3. Optimized Ruff Configuration
[format]
section toruff.toml
with formatter settings4. Verification
ruff check
validations now pass with zero errorsruff format
checks passImpact
The codebase now has consistent trailing comma usage throughout and is fully compatible with ruff 0.12.3. This change improves code consistency and prepares the repository for future ruff updates.
Files Changed
pyproject.toml
: Updated ruff version requirementruff.toml
: Added formatter config and updated rule selectionFixes #19812.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
pypi.chia.net
/usr/bin/python3 /home/REDACTED/.local/bin/poetry install --extras dev
(dns block)/usr/bin/python3 /home/REDACTED/.local/bin/poetry update ruff
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.