Skip to content

Conversation

Quexington
Copy link
Contributor

This ports the main CAT RPC test to use the `WalletTestFramework and then to parametrize it to also test R-CATs.

One R-CAT issue was identified when porting this test. When converting a previous CAT wallet to an R-CAT wallet, the old CAT puzzles hashes are left in the derivation DB. A single line was added to delete these before rederiving the new puzzle hashes.

@Quexington Quexington force-pushed the quex.port_cat_tests_to_also_r_cats branch from 18456da to 4fde494 Compare July 15, 2025 12:16
@Quexington Quexington added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Jul 15, 2025
@Quexington Quexington marked this pull request as ready for review July 15, 2025 12:18
@Quexington Quexington requested a review from a team as a code owner July 15, 2025 12:18
@Quexington Quexington requested a review from AmineKhaldi July 15, 2025 12:29
@Quexington Quexington changed the title [CHIA-3384] Port test_cat_endpoints in test_wallet_rpc.py to WalletTestFramework and R-CATs [CHIA-3388] Port test_cat_endpoints in test_wallet_rpc.py to WalletTestFramework and R-CATs Jul 15, 2025
@emlowe
Copy link
Contributor

emlowe commented Jul 15, 2025

close and reopen for 3.9 CI fix

@emlowe emlowe closed this Jul 15, 2025
@emlowe emlowe reopened this Jul 15, 2025
@Starttoaster Starttoaster merged commit 96d1356 into release/2.5.5 Jul 15, 2025
3041 of 3055 checks passed
@Starttoaster Starttoaster deleted the quex.port_cat_tests_to_also_r_cats branch July 15, 2025 22:43
Starttoaster added a commit that referenced this pull request Jul 23, 2025
[CHIA-3388] Port `test_cat_endpoints` in `test_wallet_rpc.py` to `WalletTestFramework` and R-CATs (#19818)

* Port `test_cat_endpoints` to `WalletTestFramework`

* Use mint_cat from cat tests

* Add RCAT parametrization

* Delete now unnecessary `from_zero`

* Minor clarification.

---------

Co-authored-by: Matt Hauff <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants