Skip to content

CHIA-3396 Remove Exception Catching from node RPC #19825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 21, 2025
Merged

CHIA-3396 Remove Exception Catching from node RPC #19825

merged 6 commits into from
Jul 21, 2025

Conversation

jack60612
Copy link
Contributor

Purpose:

Makes Python rpc client act more similarly to our other clients

Current Behavior:

All full node RPC's will not throw any exceptions

New Behavior:

Full Node RPC's will throw exceptions if there is an error in receiving the response.

Testing Notes:

TBD

@jack60612 jack60612 changed the title Remove Arbitrary Exception Catching from full-node RPC CHIA-3396 Remove Arbitrary Exception Catching from full-node RPC Jul 15, 2025
@jack60612 jack60612 changed the title CHIA-3396 Remove Arbitrary Exception Catching from full-node RPC CHIA-3396 Remove Exception Catching from node RPC Jul 15, 2025
@jack60612 jack60612 added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Jul 15, 2025
@jack60612 jack60612 requested a review from arvidn July 16, 2025 01:58
@jack60612 jack60612 marked this pull request as ready for review July 16, 2025 01:58
@jack60612 jack60612 requested a review from a team as a code owner July 16, 2025 01:58
arvidn
arvidn requested changes Jul 16, 2025
View reviewed changes
arvidn
arvidn requested changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks a lot better. just 2 issues

@github-actions GitHub Actions
Copy link
Contributor

File Coverage Missing Lines
chia/full_node/full_node_rpc_client.py 91.7% lines 55, 59-60, 190
Total Missing Coverage
73 lines 4 lines 94%

@arvidn arvidn added ready_to_merge Submitter and reviewers think this is ready and removed coverage-diff labels Jul 17, 2025
altendky
altendky reviewed Jul 17, 2025
View reviewed changes
@Starttoaster
Copy link
Contributor

Waiting on conversations to resolve prior to merge. Thanks!

@altendky
Copy link
Contributor

Waiting on conversations to resolve prior to merge. Thanks!

i just closed mine and will mention it to jack directly

@Starttoaster Starttoaster merged commit a10df3b into main Jul 21, 2025
524 of 527 checks passed
@Starttoaster Starttoaster deleted the jn.no-rpc-error branch July 21, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arvidn arvidn arvidn approved these changes

+1 more reviewer

@altendky altendky altendky left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Changed Required label for PR that categorizes merge commit message as "Changed" for changelog ready_to_merge Submitter and reviewers think this is ready

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jack60612 @Starttoaster @altendky @arvidn