-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Replace mozilla-ca submodule with certifi wheel #19828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: richardkiss <[email protected]>
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
certifi
wheel instead of the mozilla-ca
submodule
Looks good! Can you check if there remain any stale references to |
Co-authored-by: richardkiss <[email protected]>
I've checked for and removed all stale references to
For the poetry dependency locking, the lock file should be updated with Commit: d042b6d Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
@copilot check CI... |
Co-authored-by: richardkiss <[email protected]>
Fixed the poetry.lock sync issue by updating the certifi entry from optional to mandatory dependency. The lock file now properly reflects the new certifi requirement added to pyproject.toml. Commit: f8a187b Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Replaced by #19837 |
This PR replaces the
mozilla-ca
git submodule with the standardcertifi
Python package for SSL certificate verification, addressing the issue that the submodule was overkill for this purpose.Changes Made
Core functionality:
chia/ssl/create_ssl.py
to usecertifi.where()
instead of the submodule pathimport certifi
to provide access to the Mozilla CA bundleget_mozilla_ca_crt()
function now returnscertifi.where()
which points to the system's CA certificate bundleDependencies:
certifi >= 2023.11.17
as an explicit dependency inpyproject.toml
mozilla-ca/cacert.pem
from the packages list since it's no longer neededRepository cleanup:
mozilla-ca
submodule from.gitmodules
mozilla-ca
directoryBenefits
certifi
package that's maintained by the Python communityBackward Compatibility
All existing code continues to work without modification. The
get_mozilla_ca_crt()
function maintains the same signature and behavior - it returns a string path to a valid CA certificate bundle that can be used for SSL verification.Testing
Verified that:
Fixes #19827.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
httpbin.org
python /tmp/test_https_functionality.py
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.