Cleanup keys/values db. #19829
Merged
Cleanup keys/values db. #19829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchirica
added
DataLayer
Fixed
altendky
suggested changes
Jul 21, 2025
Co-authored-by: Kyle Altendorf <[email protected]>
altendky
suggested changes
Jul 23, 2025
There was a problem hiding this comment.
using emptiness as an indicator of availability has the race hazard that if two context managers get entered at the same time for the same store id then they will both feel that they are in control. with an existence check instead and an immediate population after checking, the race risk is avoided.
Co-authored-by: Kyle Altendorf <[email protected]>
Closed
altendky
suggested changes
Jul 24, 2025
altendky
approved these changes
Jul 25, 2025
altendky
merged commit 35c03a5
into
long_lived/datalayer_merkle_blob
460 of 462 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Current Behavior:
New Behavior:
Testing Notes: