Skip to content

Conversation

almogdepaz
Copy link
Contributor

@almogdepaz almogdepaz commented Jul 16, 2025

Purpose:

prepare plot_manager to the integration of v2 plots
fix types in test_plot_manager

Current Behavior:

supports only v1 plots with plot files that end with .plot

New Behavior:

provers now implement ProverProtocol that abstracts the use of the actual prover in the plot manager
support .plot2 files with the v2 prover stubbed

Testing Notes:

@almogdepaz almogdepaz added plotting Changed Required label for PR that categorizes merge commit message as "Changed" for changelog labels Jul 16, 2025
@almogdepaz almogdepaz force-pushed the plotmanager_v2 branch 2 times, most recently from ead8e05 to d7fa2a8 Compare July 17, 2025 11:32
@almogdepaz almogdepaz requested a review from arvidn July 17, 2025 11:34
@almogdepaz almogdepaz marked this pull request as ready for review July 17, 2025 12:32
@almogdepaz almogdepaz requested a review from a team as a code owner July 17, 2025 12:32
Copy link

coveralls-official bot commented Jul 17, 2025

Pull Request Test Coverage Report for Build 16439824128

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 201 of 204 (98.53%) changed or added relevant lines in 8 files are covered.
  • 152 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+0.04%) to 91.338%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/plotting/prover.py 80 81 98.77%
chia/plotting/check_plots.py 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
chia/full_node/pending_tx_cache.py 1 96.55%
chia/consensus/pot_iterations.py 2 94.44%
chia/full_node/full_node_api.py 2 85.45%
chia/_tests/core/full_node/stores/test_block_store.py 2 99.53%
chia/timelord/timelord_launcher.py 2 90.71%
chia/server/server.py 4 82.51%
chia/_tests/wallet/sync/test_wallet_sync.py 7 98.73%
chia/server/node_discovery.py 8 80.32%
chia/_tests/util/benchmarks.py 10 75.61%
chia/full_node/full_node_rpc_client.py 16 89.29%
Totals Coverage Status
Change from base Build 16375210539: 0.04%
Covered Lines: 102076
Relevant Lines: 111634

💛 - Coveralls

Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly looks good. the double glob() makes me a bit nervous, but perhaps it's not a big deal

Copy link
Contributor

File Coverage Missing Lines
chia/plotting/check_plots.py 0.0% lines 12, 136
chia/plotting/prover.py 98.8% lines 123
Total Missing Coverage
204 lines 3 lines 98%

@Starttoaster Starttoaster merged commit 19a8329 into main Jul 30, 2025
863 of 867 checks passed
@Starttoaster Starttoaster deleted the plotmanager_v2 branch July 30, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changed Required label for PR that categorizes merge commit message as "Changed" for changelog plotting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants