-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Plotmanager v2 #19832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plotmanager v2 #19832
Conversation
ead8e05
to
d7fa2a8
Compare
Pull Request Test Coverage Report for Build 16439824128Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
3f39432
to
17b0b34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly looks good. the double glob()
makes me a bit nervous, but perhaps it's not a big deal
f8013e1
to
e3a8cfc
Compare
|
Purpose:
prepare plot_manager to the integration of v2 plots
fix types in test_plot_manager
Current Behavior:
supports only v1 plots with plot files that end with .plot
New Behavior:
provers now implement ProverProtocol that abstracts the use of the actual prover in the plot manager
support .plot2 files with the v2 prover stubbed
Testing Notes: