Skip to content

Conversation

altendky
Copy link
Contributor

Purpose:

i am not aware of a time where it was ever required at runtime to pre-int() the parameters to the fixed width integers. but... the hinting was wrong and that did push towards this practice. hinting was fixed (well, closer to accurate) a couple years ago perhaps. just another cleanup psas here around old practices.

Current Behavior:

New Behavior:

Testing Notes:

@altendky altendky added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels Jul 21, 2025
@altendky altendky requested a review from a team as a code owner July 21, 2025 13:30
@altendky altendky requested a review from emlowe July 21, 2025 13:32
Copy link
Contributor

File Coverage Missing Lines
chia/consensus/block_rewards.py 33.3% lines 24, 26, 28, 30, 47, 49, 51, 53
chia/simulator/block_tools.py 0.0% lines 1314
Total Missing Coverage
49 lines 9 lines 81%

Copy link

Pull Request Test Coverage Report for Build 16418389109

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 40 of 49 (81.63%) changed or added relevant lines in 27 files are covered.
  • 11 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.03%) to 91.325%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/simulator/block_tools.py 0 1 0.0%
chia/consensus/block_rewards.py 4 12 33.33%
Files with Coverage Reduction New Missed Lines %
chia/full_node/full_node.py 1 88.24%
chia/full_node/pending_tx_cache.py 1 96.55%
chia/wallet/util/wallet_sync_utils.py 1 86.07%
chia/full_node/full_node_api.py 2 85.52%
chia/server/node_discovery.py 2 82.11%
chia/wallet/wallet_node.py 4 87.45%
Totals Coverage Status
Change from base Build 16375210539: 0.03%
Covered Lines: 101938
Relevant Lines: 111503

💛 - Coveralls

@Starttoaster Starttoaster merged commit 7a26610 into main Jul 23, 2025
520 of 523 checks passed
@Starttoaster Starttoaster deleted the less_preinting_for_ints branch July 23, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants