Skip to content

CHIA-3484 Handle items that spend an older ff version when newer lineage exists #19865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2025
Merged

CHIA-3484 Handle items that spend an older ff version when newer lineage exists #19865

merged 1 commit into from
Jul 25, 2025

Conversation

AmineKhaldi
Copy link
Contributor

@AmineKhaldi AmineKhaldi commented Jul 24, 2025 •
edited
Loading

This is an addendum to PR #19355.

  • Handle items that spend an older ff version when newer lineage exists.
  • Gracefully handle expected but missing coin IDs in mempool items during spend bundle validation.
  • The added test fails without the fix.

@AmineKhaldi AmineKhaldi self-assigned this Jul 24, 2025
@AmineKhaldi AmineKhaldi added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Jul 24, 2025
@AmineKhaldi AmineKhaldi force-pushed the gracefully_handle_key_error_check_removals branch from 3a9e5d1 to 37518fc Compare July 24, 2025 21:22
@AmineKhaldi AmineKhaldi changed the title CHIA-3484 Gracefully handle expected but missing coin IDs in mempool items during spend bundle validation CHIA-3484 Handle items that spend an older ff version when newer lineage exists Jul 24, 2025
@AmineKhaldi AmineKhaldi force-pushed the gracefully_handle_key_error_check_removals branch from 37518fc to bd1765d Compare July 24, 2025 21:44
@AmineKhaldi AmineKhaldi marked this pull request as ready for review July 24, 2025 21:45
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner July 24, 2025 21:45
wjblanke
wjblanke approved these changes Jul 25, 2025
View reviewed changes
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@Starttoaster Starttoaster merged commit 5200310 into Chia-Network:release/2.5.5 Jul 25, 2025
1524 of 1527 checks passed
arvidn
arvidn reviewed Jul 29, 2025
View reviewed changes
Starttoaster added a commit that referenced this pull request Aug 13, 2025
@Starttoaster
checkpoint: into main from release/2.5.5 @ 5200310 (#19925)
ae2243e 
CHIA-3484 Handle items that spend an older ff version when newer lineage exists (#19865)

Handle items that spend an older ff version when newer lineage exists.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arvidn arvidn arvidn left review comments

@wjblanke wjblanke wjblanke approved these changes

Assignees

@AmineKhaldi AmineKhaldi

Labels

Changed Required label for PR that categorizes merge commit message as "Changed" for changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AmineKhaldi @arvidn @wjblanke @Starttoaster