[CHIA-3633] August 2025 pass of Ruff linting rules

[Quexington]

It's been a couple of months since the most recent rules were added to Ruff so I figured it's time to do another pass of some low-hanging fruit of rules to enable.

This PR enables 6 new rules and deletes one unused ignore. It's highly recommended to review the PR one commit at a time and for the elif change to hide whitespace.

[Copilot]

Pull Request Overview

This PR enables 6 new Ruff linting rules and removes one unused ignore rule to improve code quality. The changes focus on simplifying control flow by collapsing else-if statements and resolving variable shadowing issues.

• Converts nested else-if statements to elif for cleaner control flow
• Fixes variable shadowing where loop variables or function parameters reused names in their scope
• Removes unnecessary type casting to int where the operation already returns an integer

Reviewed Changes

Copilot reviewed 57 out of 57 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tools/cpu_utilization.py	Adds noqa comment for loop variable modification
ruff.toml	Removes 6 ignored Ruff rules to enable new linting checks
chia/wallet/wallet_transaction_store.py	Simplifies nested else-if to elif
chia/wallet/wallet_state_manager.py	Fixes variable shadowing by renaming variables
chia/wallet/wallet_node.py	Converts multiple nested else-if statements to elif
chia/wallet/vc_wallet/vc_wallet.py	Simplifies nested conditional structure
chia/wallet/util/merkle_utils.py	Resolves variable shadowing in loop
chia/wallet/puzzle_drivers.py	Converts else-if to elif
chia/wallet/nft_wallet/nft_wallet.py	Fixes variable shadowing in loop
chia/wallet/cat_wallet/cat_outer_puzzle.py	Resolves variable shadowing
Multiple other files	Similar pattern of else-if to elif conversions and variable shadowing fixes

[github-actions]

File	Coverage	Missing Lines
chia/_tests/blockchain/blockchain_test_utils.py	50.0%	lines 122
chia/_tests/core/full_node/test_full_node.py	54.5%	lines 3168-3172
chia/cmds/wallet_funcs.py	60.0%	lines 270, 1250
chia/consensus/block_header_validation.py	97.4%	lines 1044
chia/consensus/get_block_challenge.py	84.2%	lines 97-99
chia/data_layer/data_layer_wallet.py	80.0%	lines 594, 598
chia/data_layer/data_store.py	95.8%	lines 1508
chia/plotting/check_plots.py	0.0%	lines 173, 175, 186, 188, 210
chia/plotting/create_plots.py	50.0%	lines 88
chia/seeder/crawl_store.py	0.0%	lines 198-201
chia/server/node_discovery.py	50.0%	lines 232-233
chia/server/server.py	0.0%	lines 263-264
chia/timelord/timelord.py	33.3%	lines 165-167, 171
chia/util/db_wrapper.py	66.7%	lines 134
chia/wallet/nft_wallet/nft_wallet.py	0.0%	lines 553-555
chia/wallet/wallet_node.py	81.8%	lines 1160, 1274, 1663-1664

Total	Missing	Coverage
309 lines	41 lines	86%

[emlowe]

coverage exempted