Skip to content

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Aug 11, 2025

Current Behavior:

check_plot_size() only considers MAX_PLOT_SIZE_* and MIN_PLOT_SIZE_*.

New Behavior:

check_plot_size() also disallows odd k-sizes for v2 plots.

@arvidn arvidn requested a review from a team as a code owner August 11, 2025 08:15
@arvidn arvidn requested a review from almogdepaz August 11, 2025 08:16
@arvidn arvidn added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Aug 11, 2025
@arvidn arvidn requested a review from wjblanke August 11, 2025 11:17
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@arvidn arvidn added the ready_to_merge Submitter and reviewers think this is ready label Aug 12, 2025
@Starttoaster Starttoaster merged commit df45f39 into main Aug 13, 2025
520 of 522 checks passed
@Starttoaster Starttoaster deleted the check-plot-size branch August 13, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changed Required label for PR that categorizes merge commit message as "Changed" for changelog ready_to_merge Submitter and reviewers think this is ready

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants