Skip to content

checkpoint: into main from release/2.5.5 @ b1cc0a5b84a9c517ad55da2ce87e5378dcdccb32 #19955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2025
Merged

checkpoint: into main from release/2.5.5 @ b1cc0a5b84a9c517ad55da2ce87e5378dcdccb32 #19955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1cc0a5
fast-forward spends can be treated as regular spends (#19889)
arvidn Aug 1, 2025
a3a3b01
Merge commit 'b1cc0a5b84a9c517ad55da2ce87e5378dcdccb32' into checkpoi…
AmineKhaldi Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion chia/_tests/core/mempool/test_singleton_fast_forward.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,4 +663,4 @@ async def test_double_spend_ff_spend_no_latest_unspent() -> None:
status, error = await make_and_send_spend_bundle(sim, sim_client, [singleton_coin_spend], aggsig=sig)
# It fails validation because it doesn't currently have a latest unspent
assert status == MempoolInclusionStatus.FAILED
assert error == Err.DOUBLE_SPEND
assert error == Err.UNKNOWN_UNSPENT
11 changes: 8 additions & 3 deletions chia/full_node/mempool_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,11 +625,16 @@ async def validate_spend_bundle(
eligible_for_ff = bool(spend_conds.flags & ELIGIBLE_FOR_FF) and supports_fast_forward(coin_spend)
if eligible_for_ff:
# Make sure the fast forward spend still has a version that is
# still unspent, because if the singleton has been melted, the
# fast forward spend will never become valid.
# still unspent, because if the singleton has been spent in a
# non-FF spend, this fast forward spend will never become valid.
# So treat this as a normal spend, which requires the exact coin
# to exist and be unspent.
# Singletons that were created before the optimization of using
# spent_index will also fail this test, and such spends will
# fall back to be treated as non-FF spends.
lineage_info = await get_unspent_lineage_info_for_puzzle_hash(spend_conds.puzzle_hash)
if lineage_info is None:
return Err.DOUBLE_SPEND, None, []
eligible_for_ff = False

spend_additions = []
for puzzle_hash, amount, _ in spend_conds.create_coin:
Expand Down
Loading