Skip to content

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Aug 14, 2025

Purpose:

In block_tools.py, the get_pospaces_for_challenge() function has unnecessarily deep nesting of if-blocks.
This PR is best reviewed ignoring whitespace, since there are many lines whose indentation level changed.

This PR is best reviewed ignoring whitespaces. https://github.com/Chia-Network/chia-blockchain/pull/19957/files?diff=split&w=1

@arvidn arvidn requested a review from a team as a code owner August 14, 2025 12:19
@arvidn arvidn marked this pull request as draft August 14, 2025 12:19
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Aug 14, 2025
@arvidn arvidn closed this Aug 14, 2025
@arvidn arvidn reopened this Aug 14, 2025
@arvidn arvidn force-pushed the block-tools-indentation branch from 024c8d1 to 1011c41 Compare August 15, 2025 06:23
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Aug 15, 2025
@arvidn arvidn added the Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes label Aug 15, 2025
@arvidn arvidn marked this pull request as ready for review August 15, 2025 06:42
@arvidn arvidn added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Aug 15, 2025
@arvidn arvidn requested a review from AmineKhaldi August 15, 2025 07:49
@arvidn arvidn requested a review from wjblanke August 15, 2025 15:28
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@Starttoaster Starttoaster merged commit 8b49b06 into main Aug 18, 2025
523 of 527 checks passed
@Starttoaster Starttoaster deleted the block-tools-indentation branch August 18, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants