optimize get_spends RPC #19958
Open
optimize get_spends RPC #19958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvidn
added
the
Changed
arvidn
force-pushed
the
rpc-optimizations
branch
from
dd017b3 to
b7967d3
Compare
AmineKhaldi
reviewed
Aug 20, 2025
Comment on lines
-810
to
+819
|
|
||
| block: Optional[FullBlock] = await self.service.block_store.get_full_block(header_hash) | ||
| if block is None: | ||
| block_bytes: Optional[bytes] = await self.service.block_store.get_full_block_bytes(header_hash) | ||
| if block_bytes is None: | ||
| raise ValueError(f"Block {header_hash.hex()} not found") | ||
|
|
||
| block_view = memoryview(block_bytes) | ||
| height, _is_tx_block = get_height_and_tx_status_from_block(block_view) | ||
|
|
There was a problem hiding this comment.
We should be able to avoid this extra complexity by simply augmenting get_full_block_bytes to return the height as well. We have it in the full_blocks table it already queries.
Comment on lines
-237
to
+258
| buf = skip_reward_chain_block(buf) # reward_chain_block | ||
| buf, height = height_from_reward_chain_block(buf) # reward_chain_block |
There was a problem hiding this comment.
We can avoid this added complexity by receiving height in block_info_from_block if we must (to keep returning this augmented GeneratorBlockInfo) instead of computing it. The caller has it already.
|
This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed by the relevant parties. |
github-actions
bot
added
the
stale-pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Make some of the RPCs a bit cheaper.
GeneratorBlockInfoinclude block height. This makes it possible to run the block generator just from this information.get_full_block()->get_block_info()in the RPCs that run blocks (which is cheaper).get_puzzle_and_solution_for_coin()in the thread pool for RPCs.get_additions_and_removalsis really just a coin store lookup. We currently get the full block just to map the header hash to a height. Change this to parse out the block height withget_height_and_tx_status_from_block()instead of constructing a full block.Current Behavior:
New Behavior: