Skip to content

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Aug 15, 2025

Purpose:

pass the correct previous_transaction_block_height into validate_pospace_and_get_required_iters() in BlockTools.

The main change is in load_block_list() in BlockTools. We call this function when block tools is asked to generate blocks on top of an existing chain. Rather than always setting prev_transaction_b_height to 0, we hoist it out of the loop and update it as we encounter transaction blocks.

The other change is the tracking of previous transaction blocks in the main loop in get_consecutive_blocks(), only update prev_tx_height when we actually produce a transaction block.

@arvidn arvidn added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Tests Changes to tests Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels Aug 15, 2025
@arvidn arvidn requested a review from almogdepaz August 15, 2025 15:26
@arvidn arvidn marked this pull request as ready for review August 15, 2025 15:27
@arvidn arvidn requested a review from a team as a code owner August 15, 2025 15:27
@arvidn arvidn requested a review from wjblanke August 18, 2025 22:31
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@arvidn arvidn added the ready_to_merge Submitter and reviewers think this is ready label Aug 21, 2025
@pmaslana pmaslana merged commit 74d5c45 into main Aug 21, 2025
520 of 524 checks passed
@pmaslana pmaslana deleted the prev-tx-block branch August 21, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes ready_to_merge Submitter and reviewers think this is ready Tests Changes to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants