[CHIA-3654] previous transaction block height in BlockTools #19962
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
pass the correct
previous_transaction_block_height
intovalidate_pospace_and_get_required_iters()
inBlockTools
.The main change is in
load_block_list()
inBlockTools
. We call this function when block tools is asked to generate blocks on top of an existing chain. Rather than always settingprev_transaction_b_height
to 0, we hoist it out of the loop and update it as we encounter transaction blocks.The other change is the tracking of previous transaction blocks in the main loop in
get_consecutive_blocks()
, only updateprev_tx_height
when we actually produce a transaction block.