Skip to content

[CHIA-3701] cleanup check_plots #19981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 26, 2025
Merged

[CHIA-3701] cleanup check_plots #19981

merged 3 commits into from
Aug 26, 2025

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Aug 21, 2025 •
edited
Loading

This is best reviewed one commit at a time, and ignoring whitespace.

Purpose:

Simplify check plots:

  1. use monotonic() clock when measuring time of operations
  2. move exception handling blocks to reduce indentation level. This commit is best viewed ignoring whitespace.
  3. Fix type error, not caught because chiapos doesn't have type stubs

Testing

This was tested manually, via the command line chia plots check

@arvidn arvidn requested review from altendky and a team as code owners August 21, 2025 13:50
@arvidn arvidn marked this pull request as draft August 21, 2025 13:50
@arvidn arvidn added the Cleanup Code cleanup label Aug 21, 2025
@arvidn arvidn mentioned this pull request Aug 21, 2025
Merged
@arvidn arvidn changed the title cleanup check_plots [CHIA-3701] cleanup check_plots Aug 22, 2025
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Aug 22, 2025
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Aug 22, 2025
@arvidn arvidn added Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels Aug 22, 2025
@arvidn arvidn marked this pull request as ready for review August 22, 2025 22:32
@github-actions GitHub Actions
Copy link
Contributor

File Coverage Missing Lines
chia/plotting/check_plots.py 0.0% lines 8, 175-179, 184, 198, 202, 204, 206-207, 209-212, 217, 219-221, 223, 227-228, 231
Total Missing Coverage
24 lines 24 lines 0%

@arvidn arvidn requested a review from AmineKhaldi August 25, 2025 07:08
@arvidn arvidn requested a review from wjblanke August 25, 2025 10:57
wjblanke
wjblanke approved these changes Aug 25, 2025
View reviewed changes
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@arvidn arvidn added the ready_to_merge Submitter and reviewers think this is ready label Aug 25, 2025
@pmaslana pmaslana merged commit fcc0415 into main Aug 26, 2025
359 of 361 checks passed
@pmaslana pmaslana deleted the check-plots branch August 26, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmineKhaldi AmineKhaldi AmineKhaldi approved these changes

@wjblanke wjblanke wjblanke approved these changes

@altendky altendky Awaiting requested review from altendky

Assignees
No one assigned
Labels
Cleanup Code cleanup Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arvidn @AmineKhaldi @wjblanke @pmaslana