Skip to content

[CHIA-3659] ignore unreasonably small v2 plots #19984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2025
Merged

[CHIA-3659] ignore unreasonably small v2 plots #19984

merged 1 commit into from
Aug 26, 2025

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Aug 22, 2025

Purpose:

Uncompressed v1 plots that are too small, we assume are currently being copied, and not valid. This patch extends that logic to v2 plots as well

@arvidn arvidn requested a review from a team as a code owner August 22, 2025 07:34
@arvidn arvidn added the Added Required label for PR that categorizes merge commit message as "Added" for changelog label Aug 22, 2025
@arvidn arvidn requested a review from almogdepaz August 22, 2025 13:24
@github-actions GitHub Actions
Copy link
Contributor

File Coverage Missing Lines
chia/plotting/manager.py 60.0% lines 343, 349
Total Missing Coverage
5 lines 2 lines 60%

@arvidn arvidn requested a review from wjblanke August 24, 2025 22:51
wjblanke
wjblanke approved these changes Aug 25, 2025
View reviewed changes
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@arvidn arvidn added the ready_to_merge Submitter and reviewers think this is ready label Aug 25, 2025
@pmaslana pmaslana merged commit 4d2d271 into main Aug 26, 2025
520 of 523 checks passed
@pmaslana pmaslana deleted the v2-plot-manager-check-file-size branch August 26, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjblanke wjblanke wjblanke approved these changes

@almogdepaz almogdepaz almogdepaz approved these changes

Assignees
No one assigned
Labels
Added Required label for PR that categorizes merge commit message as "Added" for changelog ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arvidn @wjblanke @almogdepaz @pmaslana