Skip to content

Conversation

AmineKhaldi
Copy link
Contributor

@AmineKhaldi AmineKhaldi commented Aug 22, 2025

Purpose:

When preparing NewPeakInfo to pass from the mempool to the full node for new peak post processing, we only end up using transaction IDs Out of NewPeakItem elements.

The origin of this logic seems to be PR #1174 but even then, the mempool item should cover the information needed in that context.

Current Behavior:

We construct a list of NewPeakItems as items in NewPeakInfo.

New Behavior:

We construct a list of transaction IDs in NewPeakInfo.

@AmineKhaldi AmineKhaldi self-assigned this Aug 22, 2025
@AmineKhaldi AmineKhaldi added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Aug 22, 2025
@AmineKhaldi AmineKhaldi force-pushed the simplify_peak_post_processing branch from 0561869 to 152744f Compare August 25, 2025 10:19
@AmineKhaldi AmineKhaldi force-pushed the simplify_peak_post_processing branch from 152744f to d70e5de Compare September 8, 2025 10:44
@AmineKhaldi AmineKhaldi closed this Sep 8, 2025
@AmineKhaldi AmineKhaldi reopened this Sep 8, 2025
Copy link

coveralls-official bot commented Sep 8, 2025

Pull Request Test Coverage Report for Build 17640775329

Details

  • 12 of 12 (100.0%) changed or added relevant lines in 3 files are covered.
  • 31 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.02%) to 91.244%

Files with Coverage Reduction New Missed Lines %
chia/daemon/client.py 1 74.16%
chia/daemon/keychain_proxy.py 1 70.57%
chia/daemon/server.py 1 83.54%
chia/farmer/farmer.py 1 73.32%
chia/full_node/full_node.py 1 88.11%
chia/server/node_discovery.py 2 82.11%
chia/timelord/timelord_launcher.py 2 89.29%
chia/full_node/full_node_api.py 3 85.75%
chia/rpc/rpc_server.py 3 88.71%
chia/server/address_manager.py 5 92.84%
Totals Coverage Status
Change from base Build 17624749078: -0.02%
Covered Lines: 102833
Relevant Lines: 112566

💛 - Coveralls

@AmineKhaldi AmineKhaldi force-pushed the simplify_peak_post_processing branch from d70e5de to 7f0ee1b Compare September 11, 2025 09:50
@AmineKhaldi AmineKhaldi marked this pull request as ready for review September 11, 2025 11:10
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner September 11, 2025 11:10
@pmaslana pmaslana merged commit 698b2dd into Chia-Network:main Sep 11, 2025
344 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants