Skip to content

[CHIA-3603] Port send_notifications to @marshal #19987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Sep 19, 2025
Merged

[CHIA-3603] Port send_notifications to @marshal #19987

merged 13 commits into from
Sep 19, 2025
+95 −68

Conversation

Quexington
Copy link
Contributor

Another PR following #18593

@Quexington Quexington requested a review from a team as a code owner August 22, 2025 17:40
@Quexington Quexington changed the title [CHIA-6303] Port send_notifications to @marshal [CHIA-3603] Port send_notifications to @marshal Aug 25, 2025
@Quexington Quexington added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Aug 25, 2025
Base automatically changed from quex.port_coin_endpoints_to_marshal to main September 13, 2025 18:11
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Sep 13, 2025
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Sep 15, 2025
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Sep 15, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 17777191044

Details

  • 28 of 28 (100.0%) changed or added relevant lines in 6 files are covered.
  • 38 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.03%) to 91.135%
Files with Coverage Reduction New Missed Lines %
chia/server/node_discovery.py 1 82.11%
chia/timelord/timelord_api.py 1 93.02%
chia/farmer/farmer.py 2 73.0%
chia/full_node/full_node.py 2 87.32%
chia/timelord/timelord_launcher.py 2 89.29%
chia/util/files.py 2 91.38%
chia/rpc/rpc_server.py 3 88.09%
chia/wallet/wallet_node.py 4 86.91%
chia/plotters/bladebit.py 5 63.27%
chia/server/address_manager.py 5 92.84%
Totals Coverage Status
Change from base Build 17773649562: -0.03%
Covered Lines: 102717
Relevant Lines: 112545
💛 - Coveralls

@altendky altendky closed this Sep 16, 2025
@altendky altendky reopened this Sep 16, 2025
@altendky
Copy link
Contributor

um yeah... sorry... :[

@Quexington Quexington closed this Sep 19, 2025
@Quexington Quexington reopened this Sep 19, 2025
@pmaslana pmaslana merged commit 9d71f28 into main Sep 19, 2025
1493 of 1530 checks passed
@pmaslana pmaslana deleted the quex.port_send_notifications_to_streamable branch September 19, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@altendky altendky altendky approved these changes

@markelrod markelrod markelrod approved these changes

Assignees
No one assigned
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Quexington @altendky @markelrod @pmaslana