Skip to content

Conversation

AmineKhaldi
Copy link
Contributor

@AmineKhaldi AmineKhaldi commented Aug 27, 2025

Purpose:

Covers the scenario where new peak returns added transactions as a result of retrying potential transactions.

Current Behavior:

New Behavior:

Testing Notes:

@AmineKhaldi AmineKhaldi self-assigned this Aug 27, 2025
@AmineKhaldi AmineKhaldi added the Added Required label for PR that categorizes merge commit message as "Added" for changelog label Aug 27, 2025
Copy link

Pull Request Test Coverage Report for Build 17265005567

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 21 of 21 (100.0%) changed or added relevant lines in 1 file are covered.
  • 40 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.02%) to 91.279%

Files with Coverage Reduction New Missed Lines %
chia/daemon/client.py 1 74.72%
chia/full_node/pending_tx_cache.py 1 96.55%
chia/rpc/rpc_server.py 1 89.34%
chia/server/node_discovery.py 3 81.57%
chia/server/server.py 4 82.51%
chia/full_node/full_node.py 5 87.97%
chia/_tests/core/util/test_lockfile.py 25 77.31%
Totals Coverage Status
Change from base Build 17253036064: -0.02%
Covered Lines: 102728
Relevant Lines: 112407

💛 - Coveralls

@AmineKhaldi AmineKhaldi marked this pull request as ready for review August 28, 2025 10:38
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner August 28, 2025 10:38
@AmineKhaldi AmineKhaldi force-pushed the test_new_peak_txs_added branch from f22aeb8 to 2342216 Compare August 29, 2025 13:38
@AmineKhaldi AmineKhaldi force-pushed the test_new_peak_txs_added branch from 2342216 to b511704 Compare September 3, 2025 10:05
@AmineKhaldi AmineKhaldi closed this Sep 5, 2025
@AmineKhaldi AmineKhaldi reopened this Sep 5, 2025
@Starttoaster Starttoaster merged commit 9d1a7b9 into Chia-Network:main Sep 5, 2025
875 of 880 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added Required label for PR that categorizes merge commit message as "Added" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants