Update file_name for macOS Intel workflow #20011
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmmarslender
requested changes
Aug 29, 2025
| matrix: macos-intel | ||
| name: macOS Intel | ||
| file_name: macos | ||
| file_name: macos-intel |
There was a problem hiding this comment.
I think this is intentional, to keep consistency with the old historical intel-only filenames that existed before arm macs were a thing. Im kind of in favor of just keeping it this way and letting it get "resolved" when mac intel is no longer supported
There was a problem hiding this comment.
We likely could rename this, but there are a number of downstream workflows we'd need to update as well, that expect this particular filename
There was a problem hiding this comment.
(relevant to installers, not tests - but since we try and keep the matrix somewhat consistent...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Current Behavior:
New Behavior:
Testing Notes: