Skip to content

Conversation

AmineKhaldi
Copy link
Contributor

@AmineKhaldi AmineKhaldi commented Aug 29, 2025

Source hash: ecb54a5
Remaining commits: 1

In addition to changes in the network protocol and its generated files, between the original and this checkpoint, here are the introduced code changes in order to get back to a working state:

diff --git a/chia/_tests/harvester/test_harvester_api.py b/chia/_tests/harvester/test_harvester_api.py
index 479adb69e1..5c9e6d59ba 100644
--- a/chia/_tests/harvester/test_harvester_api.py
+++ b/chia/_tests/harvester/test_harvester_api.py
@@ -51,7 +51,7 @@ async def harvester_environment(
 
 def signage_point_from_block(
     block: FullBlock, constants: ConsensusConstants
-) -> harvester_protocol.NewSignagePointHarvester:
+) -> harvester_protocol.NewSignagePointHarvester2:
     sp_index = block.reward_chain_block.signage_point_index
     challenge_hash = block.reward_chain_block.pos_ss_cc_challenge_hash
     sp_hash = (
@@ -59,7 +59,7 @@ def signage_point_from_block(
         if block.reward_chain_block.reward_chain_sp_vdf
         else challenge_hash
     )
-    return harvester_protocol.NewSignagePointHarvester(
+    return harvester_protocol.NewSignagePointHarvester2(
         challenge_hash=challenge_hash,
         difficulty=uint64(constants.DIFFICULTY_STARTING),
         sub_slot_iters=uint64(constants.SUB_SLOT_ITERS_STARTING),
@@ -75,7 +75,7 @@ def create_test_setup(
     harvester_environment: HarvesterTestEnvironment,
     default_400_blocks: list[FullBlock],
     blockchain_constants: ConsensusConstants,
-) -> tuple[HarvesterTestEnvironment, harvester_protocol.NewSignagePointHarvester, MagicMock]:
+) -> tuple[HarvesterTestEnvironment, harvester_protocol.NewSignagePointHarvester2, MagicMock]:
     env = harvester_environment
     block = default_400_blocks[2]
     new_challenge = signage_point_from_block(block, blockchain_constants)
@@ -128,7 +128,7 @@ async def test_new_signage_point_harvester_pool_difficulty(
         sub_slot_iters=uint64(67108864),
     )
 
-    new_challenge = harvester_protocol.NewSignagePointHarvester(
+    new_challenge = harvester_protocol.NewSignagePointHarvester2(
         challenge_hash=new_challenge.challenge_hash,
         difficulty=new_challenge.difficulty,
         sub_slot_iters=new_challenge.sub_slot_iters,
diff --git a/chia/harvester/harvester_api.py b/chia/harvester/harvester_api.py
index 0ff578c74a..54fc6e159f 100644
--- a/chia/harvester/harvester_api.py
+++ b/chia/harvester/harvester_api.py
@@ -53,7 +53,7 @@ class HarvesterAPI:
     def ready(self) -> bool:
         return True
 
-    def _plot_passes_filter(self, plot_info: PlotInfo, challenge: harvester_protocol.NewSignagePointHarvester) -> bool:
+    def _plot_passes_filter(self, plot_info: PlotInfo, challenge: harvester_protocol.NewSignagePointHarvester2) -> bool:
         filter_prefix_bits = calculate_prefix_bits(
             self.harvester.constants,
             challenge.peak_height,

arvidn and others added 2 commits August 28, 2025 12:25
* support previous harvester protocol

* Update chia/protocols/harvester_protocol.py

Co-authored-by: Amine Khaldi <[email protected]>

---------

Co-authored-by: Amine Khaldi <[email protected]>
…nt/main_from_release_2.5.6_ecb54a5874681326b9ba0d0f33e68c8d718c8639
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner August 29, 2025 19:47
@AmineKhaldi AmineKhaldi added checkpoint_merge Changed Required label for PR that categorizes merge commit message as "Changed" for changelog labels Aug 29, 2025
@AmineKhaldi AmineKhaldi requested review from altendky and emlowe August 29, 2025 19:47
@AmineKhaldi AmineKhaldi marked this pull request as draft August 30, 2025 10:05
arvidn
arvidn previously approved these changes Sep 1, 2025
@AmineKhaldi AmineKhaldi closed this Sep 2, 2025
@AmineKhaldi AmineKhaldi reopened this Sep 2, 2025
@arvidn arvidn dismissed their stale review September 2, 2025 20:46

apparently there was a merge conflict

@AmineKhaldi AmineKhaldi marked this pull request as ready for review September 3, 2025 11:00
@AmineKhaldi AmineKhaldi requested a review from arvidn September 3, 2025 11:01
@pmaslana pmaslana merged commit a6cde00 into main Sep 3, 2025
1466 of 1478 checks passed
@pmaslana pmaslana deleted the checkpoint/main_from_release_2.5.6_ecb54a5874681326b9ba0d0f33e68c8d718c8639 branch September 3, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog checkpoint_merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants